U4-6233 - umbraco 7.2.1 - desktop preview - offcanvasmenu is cut off - see possible css fix

Created by Camilla Knap 04 Feb 2015, 13:08:51 Updated by Shannon Deminick 08 Apr 2017, 04:00:19

Tags: Unscheduled

Subtask of: U4-9609

What did you do? Using the preview functionality for the desktop view. Previewed a website with an off-canvas menu implemented. See attached screenshots before and after css fix.

What did you expect to happen? Expected the off-canvas menu to be fully shown in preview

What actually happened? The menu was cut off, due to the padding added to canvas body to make up for fixed left menu :-)

Possible fix. You should change the css ( canvasdesigner.css ) related to desktop version:

From this: .desktop { width: 100% margin: 0 auto; }

To this: .desktop { width: calc(100% - 80px); // 80px is the fixed left menu for toggling the different browser sizes margin: 0; }

calc is supported from IE10 and up (http://caniuse.com/#search=calc)

2 Attachments

Comments

Bruce Bjørkhaug 27 Jan 2016, 10:06:11

A year later and still not fixed in 7.3.4.


Mark Owen 15 Feb 2017, 11:57:18

Two years later and still not fixed in 7.5.3

A suggested modification to the css above would be: .desktop { width: 100%; width: calc(100% - 80px); // 80px is the fixed left menu for toggling the different browser sizes margin: 0; }

So that for browsers that don't support calc they will fall back to the existing way it works.


Mads Rasmussen 07 Apr 2017, 08:27:57

Fixed in commit: https://github.com/umbraco/Umbraco-CMS/commit/f091219f4859264b27a8afefce900a4910098861 Reviewed by claus


Claus Jensen 07 Apr 2017, 09:07:15

added escaping here: https://github.com/umbraco/Umbraco-CMS/commit/29caacf3c3aee4d1722d9212916a11e98d8ce9b4 Backported to 7.5.13 here: https://github.com/umbraco/Umbraco-CMS/commit/d6bc0934ffa1e9daaab9e02ef163860a396e0305


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.1, 7.3.4, 7.5.3

Due in version: 7.6.0, 7.5.13

Sprint: Sprint 56

Story Points:

Cycle: