U4-6409 - Uninstalling Fanoe starter kit removes Grid views

Created by Douglas Robar 17 Mar 2015, 09:48:22 Updated by Shannon Deminick 11 Jul 2017, 00:45:10

Tags: Up For Grabs

Relates to: U4-10082

Install Umbraco 7 with the default Fanoe starter kit.

Now uninstall the starter kit (via the Developer > Packages > Installed Packages section)

All files in the /Views/Partials/Grid folder are removed, making the Grid useless as there are no rendering files available. Which means calls to .GetGridHtml() will return nothing.

Uninstalling a starter kit or package should only remove the files and settings unique to the starter kit or package, not core items. (This might be related to U4-6402)

This issue makes it vital that Level 1 students do NOT install a starter kit because at this point removing the starter kit will make the Grid exercise impossible as nothing will render. The only workaround is to manually copy the /views/partials/grid files from a fresh download of the zip file.

1 Attachments

Comments

Douglas Robar 22 Sep 2015, 10:39:12

This is still an issue with 7.3.0RC

Image added for clarity.


Shannon Deminick 26 Jun 2017, 07:15:15

Closing issue due to inactivity - see blog post for details https://umbraco.com/blog/issue-tracker-cleanup/


Douglas Robar 26 Jun 2017, 10:09:26

This is still valid. Uninstalling the starter kit makes the grid unusable because core files are removed when the starter kit package is uninstalled.


Shannon Deminick 26 Jun 2017, 23:59:14

Yeah the problem is really the Fanoe kit it shouldn't replace the Grid editors. I'm not sure how we can fix this in the core if people overwrite files that are shipped with the core. There's no backups taken for core files to restore... maybe that's the only way to 'fix' this issue.


Douglas Robar 27 Jun 2017, 10:42:27

I see your point, @Shandem. Backing up files during package install so that they can be restored when uninstalled seems like a somewhat scary idea. What if you are running on v7.6, install a package that saves some core files. You upgrade your site to 7.7 and then uninstall a package. You'd be restoring the 7.6 core files. Or am I missing something there?

Perhaps the "solution" is to fix the starter kit(s). Seems like Fanoe package could be re-created without updating the core files. Then upon uninstall it wouldn't remove them. That should also be the case for the new starter kit shown at CG17. As examples of best practice. If someone makes a package that updates core files... that's their problem. Would that be reasonable?


Priority: Normal

Type: Bug

State: Open

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.0, 7.3.0, 7.2.1, 7.2.2, 7.2.8, 7.6.3

Due in version:

Sprint:

Story Points:

Cycle: