U4-6800 - DocumentType configured as ListView with Compositions editing tabs bug

Created by Robert Foster 08 Jul 2015, 03:12:14 Updated by Sebastiaan Janssen 17 Jul 2017, 15:59:48

Tags: Gold partner

Duplicates: U4-5672

Relates to: U4-5672

I've configured a DocumentType to enable list view and have added partial compositions to add in common editors (see screen shot 1).

When we go to edit a node based on this document type, some of the controls from the compositions are rendered in the first tab underneath the listview, and the listview is also rendered in the tab derived from the composition (see screen shots 2 and 3).

switching between the tabs loses the composition-based datatypes.

Note: This only seems to affect editors added to a Tab with a tab index of 0, and not all editors configured in the first tab are shown (i.e., I have two parts - a bodytext one, and an excerpt one - the bodytext one doesn't get it's controls rendered at all.

Inspecting the elements (screen shot 4) shows that the listview tab and the content tab (derived from the part compositions) are given the same id and definition.

7 Attachments

Comments

Bjarne Fyrstenborg 27 Apr 2017, 11:10:28

I have just noticed the same issue in v7.5.13 (and have also noticed it is previous versions), when list view is enabled for a document type has a composition (tab + properties are inherited from this one) in my case a composition called "Top" with a Top Image (media picker), Header (textstring) and a Sub Header (textstring).

When I disable listview for the document type, I can navigation to the tab (from the composition), but not when listview is enabled.


Bjarne Fyrstenborg 27 Apr 2017, 11:24:33

Screenshots added for when listview is enabled and disabled.


Bjarne Fyrstenborg 27 Apr 2017, 11:53:41

Another Umbraco Cloud project also use 25 as tab id for "Child items" tab, so it seems there is an issue, when you reach tab number 25 created, where the tab id no longer is unique.

I think it doesn't reserve 25 as tab id for "Child items" tab.


Bjarne Fyrstenborg 27 Apr 2017, 12:11:41

A way I could fix the issue in my case:

  • Create a copy of the composition
  • Remove the original composition from the document type
  • Add the new composition to the document type

That means the tab id is different, but unfortunately that means you loose the original data in the composition on the content nodes.

It seems the listview "Child items" tab get a specific id 25 https://github.com/umbraco/Umbraco-CMS/blob/5de21734c0aefd727d32fc66d48182201cbb00d1/src/Umbraco.Web/Models/Mapping/TabsAndPropertiesResolver.cs#L168 but when creating/adding tabs to document types (or composition document types) it probably doesn't reserve this id.


Bjarne Fyrstenborg 01 May 2017, 15:14:33

I noticed a PR for this was submitted here https://github.com/umbraco/Umbraco-CMS/pull/1552


Warren Buckley 17 Jul 2017, 08:48:12

Hi @Bjarne.Fyrstenborg I will mark this as duplicate of U4-5672


Sebastiaan Janssen 17 Jul 2017, 15:59:48

@warren.buckley Duplicates shouldn't be "due in version" else the version will keep showing it's only 99% done :-)


Priority: Normal

Type: Bug

State: Duplicate

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.6, 7.5.13

Due in version:

Sprint:

Story Points:

Cycle: 3