U4-6829 - In the new doc type editor, any composition tab should be 'locked' (readonly) however I can still click the button to add a property to it

The old doc type editor allowed you to add new properties to composition tabs. Should this be disabled for the new one? You are not allowed to edit any of the existing properties on the composition tab.

Ahhh, right, i think that actually makes sense.

In order for that to work however, you'll need to change the json you send back for properties that are added to an inherited tab. Currently this doesn't work on the back end but I can make it work fairly easily.

Currently an inherited tab has a flag "inherited: true", this will remain the same however any properties you add to that tab on the current doc type (which doesn't actually contain this tab) will need to have their flag "inherited: false". So when you send up the json for this, the tab will still contain "inherited: true" but the new property (since properties also have an inherited flag), will have "inherited: false"

What actually occurs in this scenario is that a new tab is created on the current doc type with a parentId of the inherited doc type. When the json is sent back, the previous inherited tab will now have a flag "inherited: false" with a new Id and with a parentId set.

Does that make sense?

Makes sense when you know the ContentTypeService :) - so from this, is it correct, that all Mads has to do, is to make sure that properties added to composited tabs, is to ensure they have inherited: false on them - and then mapping on the server will handle the rest.

Even tho the tab changes to be not inherited it will still have a parentId and document type names (of where it originally came from, right?)

correct! :)

... I'll have to update the mappings to support this since it currently doesn't so just let me know when this change is made in the client side and I'll update the server side.

Client side is updated now.

cool, i'll look at the server side stuff later today and re-assign this issue.

Should be fixed with U4-7372

This is still possible even after merging in U4-7372

I am not quite sure I understand what is actually going on in this thread :) As I wrote in my first comment: It is possible, in the old doc type editor, to add new properties to an inherited tab but you can not change the existing ones. Now when I reach the bottom of the comments I am not quite sure if this should be possible or not :)

Me neither - of course you should be able to add additional properties to a composition tab. And of course you should not be able to modify the existing ones. I think the original issue was (read the description) that the property added to a composition tab was not saved, ie was lost - and so the OP thought that maybe we should not be able to create it. So you should test that it can be created and it is properly saved, and then you can close the issue.

Ah gotcha! All good then! :)