Click here to create a new issue on GitHub

U4-6837 - New content type editor: availableCompositeContentTypes could be moved to service.

Created by Mads Rasmussen 14 Jul 2015, 09:08:54 Updated by Claus Jensen 16 Dec 2015, 11:34:49

Subtask of: U4-112

Right know all available composite content types is part of the content type model. To clean up the model we could move availableCompositeContentTypes to it’s own service and follow the pattern from available templates and available content types (child nodes).

Comments

Shannon Deminick 15 Dec 2015, 11:28:02

PR is here: https://github.com/umbraco/Umbraco-CMS/pull/951

Along with moving the availableCompositeContentTypes from the model to a separate service, this PR also does:

  • Allows for assigning compositions to doc types that are being created.
  • Removes unused getAssignedListViewDataType from contentTypeResource.
  • Removes unused getPropertyTypeScaffold from memberTypeResource.
  • Removes unused performContainerDelete from memberTypeResource - since member types don't support folders.
  • Ensures correct security for the ContentTypeController.GetAllPropertyTypeAliases and ContentTypeController.GetAvailableCompositeContentTypes.
  • Removes unused ContentTypeControllerBase.GetAssignedListViewDataType, this is no longer used because the list view is configured using the DataTypeController.
Claus Jensen 16 Dec 2015, 11:12:39

Seems good to me - I've tested that creating document types with composition (on creating) works. Also tested adding in properties on the doctype itself - on a tab inherited from composition, then deleting the composition - everything seems to work as intended.

Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 5

Story Points:

Cycle: