U4-6844 - Potential perf issue with new Domain service

Created by Stephan 16 Jul 2015, 07:42:01 Updated by Stephan 21 Jul 2015, 13:21:24

Relates to: U4-6845

See https://our.umbraco.org/forum/umbraco-7/using-umbraco-7//67651-really-slow-startup-with-v73-beta

It looks like each time we get the url of a node, we re-load all the domains from the database. I think that before we had the new Domain service, all domains would be cached at some point, and maybe that cache is gone.

Note: we should have a proper DomainCache alongside ContentCache, MediaCache, etc. It already exists in the -contentcache branch, must see whether it is possible to backport.

Comments

Shannon Deminick 16 Jul 2015, 15:34:04

Yup i can see the issue, will fix


Shannon Deminick 16 Jul 2015, 16:10:44

I've fixed this in rev: b5cf3e9f596a87fb0e98b328f75eecb27e30a531

@zpqrtbnk All domains are always cached now and that is the only domain cache at the repo level, let's make sure there's not another DomainCache someplace as it's probably not needed


Stephan 16 Jul 2015, 16:32:13

Mmm... in the -contentcache branch there's a "DomainCache" alongside the content & media cache... but IIC now the repository just keeps all domains in cache, and refreshes anytime a domain changes, right? Then I might not need it at all. Nice.


Shannon Deminick 21 Jul 2015, 08:17:54

@zpqrtbnk let me know if you do/dont get a chance to test this, from my tests it is working as it should


Stephan 21 Jul 2015, 13:21:21

Have run tests where I list 300-400 documents ''and'' their .Url, while monitoring with dotTrace. Used to report database accesses for domains as the major perfs issue, now it's all gone. Assuming the issue is fixed.


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: