U4-693 - UmbracoImageMediaFactory doesn't support png images

Created by Jeroen Breuer 26 Aug 2012, 14:21:49 Updated by Matt Brailsford 27 Aug 2012, 09:18:12

Relates to: U4-694

Subtask of: U4-109

I just had a look at the UmbracoImageMediaFactory (used for DMU and the new uploader in 4.9) and it doesn't support png images yet. If I create an image with the upload datatype it does work. See attachment.

1 Attachments

Comments

Matt Brailsford 27 Aug 2012, 09:02:33

Fixed in changset 762f9e1be1f8

---

Jeroen Breuer 27 Aug 2012, 09:07:49

I've looked at what's changed (http://umbraco.codeplex.com/SourceControl/changeset/762f9e1be1f8), but I still see thumbDestFilePath + ".jpg" in the code for the thumbnail. Doesn't this mean that the thumbnail is still a jpg image and will look the same as the attached screenshot?

---

Matt Brailsford 27 Aug 2012, 09:12:25

I've brought it inline with how UmbracoFile works which saves thumbnails with the .jpg file extension but using the image/png codec. It's the codec that tells it to be transparent. I'm not 100% sure why we keep the .jpg extension, my guess would be for compatibility should people be relying on the .jpg extension, but as this is how UmbracoFile works, I went for consistency.

---

Matt Brailsford 27 Aug 2012, 09:17:39

I've raised a separate issue for this is it affects more than the UmbracoImageMediaFactory

http://issues.umbraco.org/issue/U4-694

---