U4-6953 - DatePicker (with time?) seems to be misbehaving since 7.2.8 in Firefox

Created by Sebastiaan Janssen 11 Aug 2015, 17:24:50 Updated by Sebastiaan Janssen 10 Dec 2015, 16:47:08

Is duplicated by: U4-7523

See:

https://our.umbraco.org/projects/backoffice-extensions/u7-grid-data-type/questions-bugs-issues-feedback/70317-datepicker-not-populating-correctly-umbraco-728

and: https://our.umbraco.org/forum/umbraco-7/using-umbraco-7/69488-datepicker-broken-in-728#comment-226798

That last one I can reproduce in Firefox (not Chrome).

1 Attachments

Comments

Allan Hawkey 14 Aug 2015, 13:15:41

@sebastiaan the same problem exists in IE11 and Edge in addition to Firefox - it only seems to work correctly in Chrome.


Shannon Deminick 20 Aug 2015, 12:11:09

The issue seen with the Document Type Grid editor, which @matt has fixed in the doc type grid editor core.


Shannon Deminick 20 Aug 2015, 13:24:03

The Firefox issue is because there's a bug in Firefox, we were doing a:

new Date("2015-08-20 14:11:34")

which results in: Invalid Date

This works perfectly fine in all browsers, and probably used to work in firefox. To fix we are now using "moment" for all date patterns in this property editor.

This issue would surely be causing havoc in a few apps with FF out there.


Allan Hawkey 20 Aug 2015, 13:37:47

Thanks Shannon - is there a fix I can apply into my 7.2.8 site for this?


Sebastiaan Janssen 20 Aug 2015, 13:47:34

This commit is where it's fixed: https://github.com/umbraco/Umbraco-CMS/commit/10108d75b8746d4697df3feea9ec41eab81f56f7


Sebastiaan Janssen 20 Aug 2015, 13:48:00

(though I'm not sure if that's 7.2.8 compatible)


Shannon Deminick 20 Aug 2015, 14:58:22

It's just this block that fixes the FF issue:

https://github.com/umbraco/Umbraco-CMS/commit/10108d75b8746d4697df3feea9ec41eab81f56f7#diff-c132d39c5610e63aaece383f00bac5beR100


Shannon Deminick 20 Aug 2015, 14:58:31

which should work with 7.2.8


Allan Hawkey 20 Aug 2015, 15:37:40

@Shandem thanks - that seems to have worked!


Eric Schrepel 01 Sep 2015, 22:38:03

I don't know if it's related, but since our upgrade to 7.2.8, we find the date as displayed in the UI often doesn't match the date in the calendar drop-down (see attached image). So our users get confused. Sometimes picking a date from the calendar then ends up saving a date result that's a day before what they intended to pick on the calendar.


nik mihalick 02 Sep 2015, 18:20:54

I experience the same issue as @Eric.Schrepel mentioned and opened up UA-7061 to detail the issue.


Peter Steiner 10 Sep 2015, 08:37:53

I have applied the fix to a 7.2.8 release, you can find a hotfix of the file \Umbraco\Js\umbraco.controllers.js at

http://pastebin.com/V1nCCAYw

To apply the patch, simply replace umbraco.controllers.js and update dependency cache.

Note that this issue affects all FF and IE users (http://dygraphs.com/date-formats.html).

According to the Umbraco system requirements, Firefox (Latest) and IE10+ are fully supported browsers, so I find it a little bit disconcerting that a core built-in data type editor simply breaks in a maintenance release without being noticed by the release QA.


Eric Schrepel 10 Sep 2015, 16:16:31

This fixed the disconnect between the dropdown calendar and displayed date, thanks a ton. (I realize I'm not well versed in Umbraco patches, so took a moment to understand that clearing the dependency cache meant just deleting app_data/temp/clientdependency folder then hard-reloading the page in Chrome.) Also, this problem affected Chrome as well as FF and IE.


Shannon Deminick 10 Sep 2015, 17:04:32

(you should just increment the CDF version in the /config/clientdependency.config fiel)


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.8

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: