We have moved to GitHub Issues
Created by Shannon Deminick 20 Aug 2015, 08:04:30 Updated by Shannon Deminick 16 Nov 2016, 13:01:36
Relates to: U4-5427
Relates to: U4-5618
The remaining known N+1 queries are:
Relation[Type]Repository fixed by U4-9077
ContentRepository.GetByPublishedVersion calls CreateContentFromDto which calls GetPropertyCollection which runs a SQL query to retrieve the properties - for each dto. Yet GetPropertyCollection already supports getting properties for multiple dtos at once = refactoring...
As for ScheduledPublish... it ends up using contentRepository.GetByQuery which as far as I can tell is going to run 1+1 query (+ maybe 1 if tags) but not N+1 - so considering it ok.
review = code review, + all tests should be green
This all looks absolutely fine to me and it works as well in my tests, I would like to get @Shandem to give it another look though just to be sure I'm not missing something.
Looks ok to me, hard to fully grasp the changes without a complete analysis of the logic but the code looks fine and if unit tests are passing - and they do test all of this - then we can assume it's ok. I can't see anything obvious that will cause issues.
Backwards Compatible: True
Due in version: 7.5.5
Sprint: Sprint 46