U4-7084 - Publishing a package throws an error

Created by Wouter van der Beek 10 Sep 2015, 07:37:39 Updated by Sebastiaan Janssen 23 Sep 2015, 10:26:49

Is duplicated by: U4-7088

Is duplicated by: U4-7132

What did you do?

  • Create a clean Umbraco installation with version 7.3 RC (I've seen the bug across other 7.3 betas as well)
  • Create a doctype, with a template, and then create+publish a node of that type (these steps might not even be needed)
  • Create a package. Include the newly created node, doctype, template, a language, and also some data types (doesn't matter which one)
  • Press save, then press publish

What did you expect to happen? I expected the package to be published

What actually happened? YSOD displaying a NULL reference exception. The package was not published.

After further testing it appears the error is thrown when any or all of the following are included: templates, languages, data types

Comments

Sebastiaan Janssen 10 Sep 2015, 08:37:38

Looks like happens when you select a template to package.


Stephan 11 Sep 2015, 09:07:24

Repro - by creating a package and adding just 1 template to the package.


Sebastiaan Janssen 11 Sep 2015, 09:09:21

Also applies to datatypes apparently @zpqrtbnk - see U4-7088


Stephan 11 Sep 2015, 10:28:13

Cause: the CreatedPackage class at some point does templates.Append(template.ToXml(packageManifest)) where template.ToXml(packageManifest) is supposed to return the template as an XmlNode belonging to the packageManifest XmlDocument. But due to an issue in XmlExtensions.GetXmlNode(...) the original packageManifest XmlDocument is cleared in the way. And then nothing works.

The weird thing is that all this seems to have been in place for ages (eg, 2yrs) so it's surprising the issue pops now?!


Stephan 11 Sep 2015, 11:18:00

Pushed 5dac5ed88b1ba50ae7da8dbb8b4f78851267df53 - fixes the issue, and a more general issue with XmlExtensions.GetXmlNode().


Priority: Major

Type: Bug

State: Fixed

Assignee: Stephan

Difficulty: Normal

Category: Packages

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.3.0

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: