U4-7124 - Install initial migrations data as part of BaseDataCreation instead of in DatabaseSchemaHelper

Created by Shannon Deminick 22 Sep 2015, 08:27:25 Updated by Morten Christensen 22 Sep 2015, 16:24:00

Here the convo from slack:

morten [8:19 PM] @shazwazza: as far as I can tell this insert-of-migration-version is only done as part of creating the database schema (this line specifically): https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Core/Persistence/DatabaseSchemaHelper.cs#L84 So any reason why it couldn't be part of the BaseDataCreation class where we have all the standard data inserts? -> https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Core/Persistence/Migrations/Initial/BaseDataCreation.cs (edited)

shazwazza [8:22 PM] Not sure, I don't recall a specific reason why it is there

morten [8:23 PM] Could we move it? Cause, then we don't need to do a special insert in Courier. I'd much rather have it done in the Core then having to work around it in Courier (as part of creating the schema on new sites) (edited)

shazwazza [8:24 PM] On which case that method wouldn't need the migration service passed to it. As far as I know we can move it, as long as base data creation has access to the info it needs when it's running to do the insert

morten [8:27 PM] It only needs these GlobalSettings.UmbracoMigrationName, UmbracoVersion.GetSemanticVersion() but I haven't looked into how its mapped. The result is just Umbraco, 7.3.0 from public static properties/methods IIRC

Comments

Stephan 22 Sep 2015, 16:18:11

Pushed e9afa78444f5372a03097cdf48bf524d029bcbc2 Think it does what you want @sitereactor.


Morten Christensen 22 Sep 2015, 16:24:00

Yes, perfect! And this is in 7.3.0? We need to remove a few lines from Courier now this is in place.


Priority: Normal

Type: Task

State: Fixed

Assignee: Stephan

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: