U4-7147 - Sort on "Creation date" does not work

Created by Jeffrey Schoemaker 25 Sep 2015, 06:30:25 Updated by Ashford Borough Council 04 Feb 2016, 13:51:47

Duplicates: U4-2089

When clicking on the column header "Creation date" it doesn't sort correctly. The columns "Name" and "Sort order" do.

Using Umbraco 7.2.x, with an English user.

1 Attachments

Comments

Davy Chiu 10 Nov 2015, 17:06:17

Reproduced on 7.3.x in IE11.


Ashford Borough Council 03 Feb 2016, 16:17:12

I had the same problem and after some investigation discovered the problem was caused by a mis-named variable in Umbraco/Dialogs/sort.aspx. In the code block at the bottom change dateTimeFormat: to dateFormat:. The variable name now matches the one checked in Umbraco_Client/Dialogs/SortDialog.js. and the sort works


Sebastiaan Janssen 03 Feb 2016, 17:11:02

@5devteamalerts Not sure what version you're on but this seems to be the case in 7.3.8: sort.aspx and SortDialog.js both use dateTimeFormat and it seems to work for me in Danish, UK English and US English.

I see it's been fixed in this issue: http://issues.umbraco.org/issue/U4-2089


Ashford Borough Council 04 Feb 2016, 09:57:46

We are on 7.3.0 using UK English culture. At this moment in time I can only see 7.3.7 available for download, however SortDialog.js in 7.3.7 still looks for a variable called c.dateFormat, which in sort.aspx is declared as dateTimeFormat. Only when variable dateTimeFormat in sort.aspx is changed to dateFormat to match the variable name in SortDialog.js does the sort work.


Sebastiaan Janssen 04 Feb 2016, 10:38:02

@5devteamalerts Can you please point where exactly SortDialog.js looks for dateFormat? I can't find it: https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI/umbraco_client/Dialogs/SortDialog.js#L95


Ashford Borough Council 04 Feb 2016, 11:12:15

I now see what I've done by overlooking the line 'dateFormat: self._opts.dateTimeFormat'. That means that me changing 'dateTimeFormat' to 'dateFormat' in sort.aspx has actually broken something, which bizzarely has made the sort work. This I can't explain, but for now my life needs to move on.


Sebastiaan Janssen 04 Feb 2016, 11:21:49

They both should be dateTimeFormat though, that way it also sorts hours/minutes/seconds properly :)


Ashford Borough Council 04 Feb 2016, 13:51:47

Going back to the original problem. With no changes to the original files the dates don't sort AT ALL let alone in the right order. That's just my point...nothing happens when you click the column sort arrows on the Created date column. Well, whatever I've inadvertently done I've got it working.


Priority: Normal

Type: Bug

State: Duplicate

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.2, 7.2.3, 7.2.4, 7.2.5, 7.2.6, 7.2.7, 7.2.8

Due in version:

Sprint:

Story Points:

Cycle: