U4-7182 - Replace the media image grid with flexbox

Created by Per Ploug 05 Oct 2015, 10:04:39 Updated by Shannon Deminick 23 Oct 2015, 07:48:49

Relates to: U4-7293

Subtask of: U4-7178

Our current media image grid is outdated, needs a manual refresh. Using flexbox we can do a much cleaner grid that renders faster.

Comments

Mads Rasmussen 22 Oct 2015, 10:59:44

Issue is part of PR: https://github.com/umbraco/Umbraco-CMS/pull/831


Shannon Deminick 22 Oct 2015, 13:50:42

Code seems good from glancing over it, will start testing now.

The only TODO so far is to remove the old code files that was creating the image grid. This is a 'breaking' change but that should not have been used though we can list it as a break in the tracker.


Shannon Deminick 22 Oct 2015, 14:40:50

Bug #1

When navigating to the thumbnail list and then back to the list view I get multiple JS errors:

TypeError: (t || "").match is not a function
    at Object.x.event.remove (jquery.min.js?cdv=1102612678:5)
    at HTMLDivElement.<anonymous> (jquery.min.js?cdv=1102612678:5)
    at Function.x.extend.each (jquery.min.js?cdv=1102612678:4)
    at x.fn.x.each (jquery.min.js?cdv=1102612678:4)
    at x.fn.extend.off (jquery.min.js?cdv=1102612678:5)
    at umbraco.directives.js?cdv=1102612678:4130
    at Object.e.$broadcast (angular.min.js?cdv=1102612678:94)
    at Object.e.$destroy (angular.min.js?cdv=1102612678:91)
    at angular.min.js?cdv=1102612678:157
    at angular.min.js?cdv=1102612678:100

The JS in the umbraco.directives.js that seems to be the issue is:

scope.$on("$destroy", function(){ elm.off(f);} );


Shannon Deminick 22 Oct 2015, 15:32:42

All looks good apart from the js bug mentioned


Shannon Deminick 22 Oct 2015, 15:33:03

I've also pushed some updates


Mads Rasmussen 22 Oct 2015, 18:29:41

js error bug #1 fixed: https://github.com/umbraco/Umbraco-CMS/commit/8d81d9922cb685cc21a122d50ee7ee0f7821cb10


Priority: Normal

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.4.0

Sprint: Sprint 1

Story Points:

Cycle: