We have moved to GitHub Issues
Created by Sebastiaan Janssen 14 Oct 2015, 09:04:22 Updated by Sebastiaan Janssen 22 Oct 2015, 13:38:21
Is duplicated by: U4-7291
And updated unit test (which was wrong in the first place) - https://github.com/umbraco/Umbraco-CMS/commit/62897f70640182a548d9ddf3344c76575f6012c1
This test was just wrong, you can't "update" a rule, you can add a role, you can remove a role but you can't "rename" the role. Changed this test into checking if a rule can be removed instead.
Just looking into this now but why is it not possible to update a rule ?
I can't see any code path or any usage that I can reproduce from the backoffice that would lead to an update. Maybe I'm missing something.. Just wanted you to look at it as you were the one who made the change to remove the RuleValue check from
entry.Rules.FirstOrDefault(x => x.RuleType == ruleType && x.RuleValue == newRuleValue); and I don't understand why.
Yup the AddOrUpdateRule would never work unless there was another parameter, i must have been confused at some point ;)
I've update the interface and obsoleted that method in favor of AddRule.
Backwards Compatible: True
Affected versions: 7.3.0
Due in version: 7.3.1
Sprint: Sprint 1