U4-7424 - Macro error message should be picked from language files

Created by Tommy Enger 18 Nov 2015, 12:59:24 Updated by Sebastiaan Janssen 05 Jan 2016, 09:57:16

When an error occur during rendering of a macro, you get an error message like this: "Error loading Partial View script (file: ~/Views/MacroPartials/EmailSubscription.cshtml)"

It would be nice to edit this message and translate it to different languages. It would be better for the users to see a message like "There are currently a problem rendering this part of the webpage. Please try again later or contact us at us@ourmail.com if the problem persist"

Right now, this error message is generated in: /Umbraco.Web/umbraco.presentation/macro.cs method:

public Control renderMacro(Hashtable pageElements, int pageId)

1 Attachments


Tommy Enger 21 Nov 2015, 10:56:37

Pull request: https://github.com/umbraco/Umbraco-CMS/pull/921

Tommy Enger 25 Nov 2015, 08:44:17

@Shandem Any chance this small PR can be considered for the 7.3.2 release?

Shannon Deminick 26 Nov 2015, 09:58:31

for 7.4 sure, 7.3.2 is locked now

Sebastiaan Janssen 15 Dec 2015, 13:00:47

Wasn't as simple as it seemed, I also made sure that ALL of the errors shown in the frontend can be localized.

Also made sure that when a key doesn't exist in the current language file, we look it up from the English file, see U4-7539

Tommy Enger 15 Dec 2015, 13:19:54

Great, thanks for including this! If there's any chance these 2 PRs could be considered as well when you work on language files, you get a #H5YR from all Norwegian editors this Christmas :) https://github.com/umbraco/Umbraco-CMS/pull/935 , https://github.com/umbraco/Umbraco-CMS/pull/933

Priority: Normal

Type: Usability Problem

State: Fixed


Difficulty: Normal


Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.3.1

Due in version: 7.4.0, 7.3.5

Sprint: Sprint 5

Story Points: