U4-7496 - Backoffice dropdowns quit working in Chrome after update to v47.0.2526.73

Created by jasonkvickers 03 Dec 2015, 20:41:19 Updated by Steve Morgan 16 Dec 2015, 10:53:32

Is duplicated by: U4-7499

UPDATE: if you're affected by this issue and can't upgrade to 7.3.4, a patched version of Angular can be found in the comments below: http://issues.umbraco.org/issue/U4-7496#comment=67-24646

Your report will have a greater chance of being addressed if you can give us clear steps to reproduce the issue, please answer the following questions in as much detail as possible: What did you do? Attempted to create a new datatype and edit current values within existing document and datatypes.

What did you expect to happen? When clicking on a dropdown in the backoffice, I expected to be able to select a value.

What actually happened? While the dropdown lists populate and you are able to expand the options, clicking on a value returns no response from the UI.

I discovered the issue after updating Google Chrome to the latest version (v47.0.2526.73). After attempting to debug the issue, I was able to replicate it by having my coworkers update their versions of Chrome as well.

2 Attachments

Download angular.min.js

Download angular.min.js

Comments

Andrew Parker 04 Dec 2015, 11:20:45

Yes - we're seeing the same issue this morning. Developer console doesn't report any issues.


Kevin Jump 04 Dec 2015, 13:01:57

affects other dropdowns too. can't then set things inside Nested Content, or lots of the nuPickers property editors

things like user picker/member picker don't work in content. Also standard drop down lists don't work for editors either.

You can select things using the keyboard (arrow keys - page up/down) but not the mouse


Kevin Jump 04 Dec 2015, 13:16:37

Angular / Chome issue is Here : https://code.google.com/p/chromium/issues/detail?id=565132


Martin Fenton 04 Dec 2015, 13:49:32

Is this an angular issue or a chrome issue? See also https://github.com/angular/angular.js/issues/13446 Seems like a pretty big one if no drop downs are working. Think it affects all versions of Umbraco?


Kevin Jump 04 Dec 2015, 13:53:42

@Martin.Fenton technically it's an angular issue - because it is assuming the order of events when the HTML spec is specifies that they are not in order (well change anyway) - but the language in the chrome issue suggests a chrome fix might be implemented.


Joshua Walsh 07 Dec 2015, 00:20:13

@KevinJump It is technically an AngularJS issue, but they fixed it a long time ago, which means that it's now an Umbraco issue for using such an outdated version. I wonder how much work it would take to bring Umbraco from 1.1.5 to 1.2.15 as a hotfix?


Sebastiaan Janssen 07 Dec 2015, 08:25:24

FYI: Google has fixed: https://code.google.com/p/chromium/issues/detail?id=565132#c32

Might take a while to roll out though, not sure how their release schedule works exactly.


Sebastiaan Janssen 07 Dec 2015, 10:38:26

Looks like it's going to take a while for them to roll out a fix. For now you can use this patched Angular file, put it in ~\Umbraco\lib\angular\1.1.5 (overwriting angular.min.js). This version includes the fix that the Angular people made here: https://github.com/angular/angular.js/commit/dc149de9364c66b988f169f67cad39577ba43434

Then make sure to change the version in ~\Config\ClientDependency.config to something else (just make it 1 higher or lower) and you might need to do a thorough cache cleaning in Chrome, sometimes it caches much too aggressively.

Note: despite the .min.js extension, this is the unminified version, you might want to run it through a minifier if you're concerned about the size increase from 87kb to 577kb.


Iain Martin 07 Dec 2015, 10:49:31

Cheers Seb, thought I was losing it this morning when nothing was working. Applied the patch and the dropdowns are happy again.


Kevin Giszewski 07 Dec 2015, 15:51:27

@sebastiaan +1 thanks for this.


Blake Clerke 07 Dec 2015, 22:52:58

@sebastiaan I second what @kgiszewski said, +1, thank you so much for the fix!!


Sebastiaan Janssen 08 Dec 2015, 12:36:41

I can't remove the file from the previous comment so I'll make a new comment with the properly minified file attached and remove the old comment:

Looks like it's going to take a while for them to roll out a fix. For now you can use this patched Angular file, put it in ~\Umbraco\lib\angular\1.1.5 (overwriting angular.min.js). This version includes the fix that the Angular people made here: https://github.com/angular/angular.js/commit/dc149de9364c66b988f169f67cad39577ba43434

Then make sure to change the version in ~\Config\ClientDependency.config to something else (just make it 1 higher or lower) and you might need to do a thorough cache cleaning in Chrome, sometimes it caches much too aggressively.


Sebastiaan Janssen 08 Dec 2015, 12:55:33

Commit made by '''Sebastiaan Janssen''' on ''2015-12-08T13:54:56+01:00'' https://github.com/umbraco/Umbraco-CMS/commit/d5f9dfecc465d9d5e8d44f01d3e1dd94c4822840

U4-7496 Backoffice dropdowns quit working in Chrome after update to v47.0.2526.73

#U4-7496 Fixed


Sebastiaan Janssen 08 Dec 2015, 14:27:28

7.3.4 is out now with a fix for this, so all you NuGet installers can happily update and deploy again without manual intervention! :)


Sibren Bouman 09 Dec 2015, 14:50:53

Hi Sebastiaan, I've updated to 7.3.4 for this (and the newest Chrome version), but it seems as though nothing has changed. You can mail me for more info or to start a TeamViewer-session, if you want.


Stefan Kip 09 Dec 2015, 14:53:22

@Sibren Have you tried clearing the cache? Try another instance of Chrome on another computer?


Sibren Bouman 09 Dec 2015, 14:56:54

Doh... I'm sorry, forget what I said. ;-)


Al Nicholl 09 Dec 2015, 17:20:29

Thanks for this @sebastiaan for the fix and thanks @bkclerke for tweeting about it and leading me here. #h5yr


Jason Bitman 15 Dec 2015, 21:31:37

@sebastiaan - I am still having issues with this after the upgrade to 7.3.4. Do we have to do the manual replacement of the angular files as well?


Sebastiaan Janssen 15 Dec 2015, 21:46:57

No, please follow the instructions above to update ClientDependency and clear browser cache. And then try that again, I've had reports of the cache still not reloading properly after that but it working on second try. If that really doesn't work then try to apply the manual patch, which is exactly what is included in 7.3.4 so it should not make a difference (but it's the 3rd try, which is the charm, right? ;-) ).

Also: make sure to double check that the angular.min.js file is actually different from the 7.3.3 version, you may not have overwritten it properly.


Steve Morgan 16 Dec 2015, 10:34:38

Chrome has just updated on my machine to 47.0.2526.106 - I didn't install the Angular patch and dropdowns are now working again.


Sebastiaan Janssen 16 Dec 2015, 10:42:17

Wow that was fast, is this the stable channel Steve?


Steve Morgan 16 Dec 2015, 10:53:32

Yes - nothing funky with my Chrome install. Quite impressive! http://googlechromereleases.blogspot.co.uk/

Their last comment (5 hours ago): #58 a...@chromium.org Verified the merge on the latest stable(47.0.2526.106) on Windows-7 and Linux Ubuntu 14.04 on the jsfiddle: http://jsfiddle.net/w1d8khfd/2/

This is working as intended. Hence adding the verified label.


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.3.1, 7.3.2, 7.3.3

Due in version: 7.3.4

Sprint:

Story Points:

Cycle: