U4-7524 - Markdown editor - doesn't save content changes after using buttons.

Created by Pawel Zawadzki 10 Dec 2015, 17:18:39 Updated by Pawel Zawadzki 19 Jan 2016, 13:07:24

Relates to: U4-7603

It happens when you want to put content in markdown editor and then use buttons to format it.

To reproduce:

  1. Insert some text in markdown editor
  2. Select text
  3. Format it with buttons
  4. Save (it is important to not type anything inside textarea before saving)

It looks like markdown doesn't trigger 'input' event on textarea when formatting is being applied.

Comments

Jeremy Pyne 21 Dec 2015, 21:01:36

Well, it is binding internal in angular properly because the preview updates properly. It looks like its not properly setting $dirty.


Jeremy Pyne 22 Dec 2015, 17:01:07

I have created a fix for this issues here: https://github.com/umbraco/Umbraco-CMS/pull/977

This also updated the ValueConverter so that Markdown text is converted to html when rendered with '''Umbraco.Field("markup")''' and similar methods.

(The raw markdown code can still be retrieved by the developer if needed with '''Model.Content.GetPropertyValue("markup")''' type calls. Note '''string''' as the type.)


Simon Busborg 19 Jan 2016, 11:27:31

Hey @pzawadzki1024 #h5yr for the nice work on the Markdown editor. I had to do a manuel merge to make it work with 7.4, but it's been merged now :)


Pawel Zawadzki 19 Jan 2016, 13:07:24

Ok, many thanks for your work guys :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Easy

Category: Editor

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.3.0, 7.4.0, 7.3.3

Due in version: 7.4.0

Sprint: Sprint 7

Story Points:

Cycle: