U4-7551 - New Content type editor dialog to select an editor for a property type needs the "Default" and "Reuse" tab functionality changed

Created by Shannon Deminick 16 Dec 2015, 14:53:23 Updated by Sebastiaan Janssen 15 Jul 2016, 11:38:20

Relates to: U4-8728

Currently there are 2 tabs:

"Default"

This shows either:

  • Property Editors that haven't been assigned to Data Types
  • Data Types that don't have Pre-values

"Reuse" (NOTE: This needs to be renamed since Reuse isn't a word)

  • Data types that have been created that have pre-values

This is confusing and will cause problems. For example:

  • Ensure there is no data type in the data type tree of type Member Group Picker
  • Then create a property type of type Member Group Picker -> it will force you to create a data type since there isn't one (leave the default name)
  • Then create another property type, you will no longer find an editor called "Member Group Picker", it will be renamed to the data type just created
  • You will also no longer be able to create a new one of that type

Solution

The solution is easy:

  • The first tab should be renamed to "Available Editors"
  • The first tab will just display all available Property Editors -> clicking on any of these will always create a new data type
  • The second tab can be renamed "Re-use"
  • The second tab will display all data types

Comments

Shannon Deminick 16 Dec 2015, 14:54:25

To fix this we just need to change how the GetGroupedPropertyEditors works


Niels Hartvig 16 Dec 2015, 15:26:47

Perfect - nice and clean!


Shannon Deminick 16 Dec 2015, 15:52:02

PR here: https://github.com/umbraco/Umbraco-CMS/pull/961

It works as advertised above... so much better IMO and no longer confusing.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 5

Story Points:

Cycle: