U4-7578 - Can't pick folders in any media picker in 7.4 beta

Created by Sebastiaan Janssen 18 Dec 2015, 10:40:02 Updated by Sebastiaan Janssen 12 Jan 2016, 16:45:18

Relates to: U4-7387

Neither the media picker nor the legacy media picker seem to allow me to pick folder.

3 Attachments

Comments

Veronica Burd 18 Dec 2015, 10:52:13

I found that my version of umbraco\Views\propertyeditors\listview\layouts\grid\grid.html was not the same as the one in the PR for 7387 i.e. <div ng-controller="Umbraco.PropertyEditors.ListView.GridLayoutController as vm" '''ng-if="items"'''>

was missing the ng-if. However, adding this still hasn't solved my issue.


Mads Rasmussen 21 Dec 2015, 13:51:35

PR: https://github.com/umbraco/Umbraco-CMS/pull/968

Test that it is possible to select folders in media picker


Shannon Deminick 22 Dec 2015, 09:18:48

We'll need to adjust how the folders are displayed in the picker:


Shannon Deminick 22 Dec 2015, 09:19:58

Other than that, I can verify that I can click on a folder in the media pickers in order to navigate to the media inside the folder.


Shannon Deminick 28 Dec 2015, 09:40:40

@madsrasmussen not sure if you're on holidays or not but this has been put back in re-work. This same PR also affects the other issue: U4-7548


Mads Rasmussen 28 Dec 2015, 11:04:40

@Shandem I am here.. Yes I have seen that you re-opened the task again and yes, you are right, there is an issue with the media grid if you upload small images. I will see if I can find a solution for this. I am not quite sure how this issue is connected to U4-7548?


Shannon Deminick 28 Dec 2015, 11:09:28

oops, sorry meant this one: http://issues.umbraco.org/issue/U4-7582


Mads Rasmussen 08 Jan 2016, 10:07:04

I have updated the PR: https://github.com/umbraco/Umbraco-CMS/pull/968 so media items now have a min. size. I have also streamlined the way you select folders in the media library and media picker with the way we do en list views - click on item to select, click on name to go to item.


Shannon Deminick 11 Jan 2016, 16:56:14

Hrm, still seems to be some issue here:

  • When you try to select a folder in the markdown editor's image picker, you get a JS error. Also, in this case you shouldn't be able to actually select a folder because you cannot display a folder in html.
TypeError: Cannot read property 'replace' of undefined
  at properlyEncoded (markdown.editor.js?umb__rnd=7.4.0-beta.313679339:1589)
  at linkEnteredCallback (markdown.editor.js?umb__rnd=7.4.0-beta.313679339:1657)
  at Object.$scope.mediaPickerOverlay.submit (umbraco.controllers.js?cdv=313679339:12230)
  at Object.scope.submitForm (umbraco.directives.js?cdv=313679339:3689)
  at angular.min.js?cdv=313679339:74
  at Object.e.$eval (angular.min.js?cdv=313679339:92)
  at Object.e.$apply (angular.min.js?cdv=313679339:92)
  at HTMLFormElement.<anonymous> (angular.min.js?cdv=313679339:156)
  at HTMLFormElement.x.event.dispatch (jquery.min.js?cdv=313679339:5)
  at HTMLFormElement.y.handle (jquery.min.js?cdv=313679339:5)
  • When you try to select a folder in the rich text editor's image picker - you don't get a JS error but it renders an empty image - similar to the markdown editor, you shouldn't be able to actually select a folder in this case
  • If you select a folder for a multiple media picker I'm not sure if the styling is correct (see attached Image):
  • If you create a new Macro, give it a property with a macro parameter type of Multiple Media Picker, then in the template editor, insert this macro and in the dialog the styling is not consistent with the content editor (see attached Image)


Claus Jensen 12 Jan 2016, 09:40:35

PR for the markdown/rte part: https://github.com/umbraco/Umbraco-CMS/pull/1011 Reassigning to @madsrasmussen for review and checking up on the styling parts.


Mads Rasmussen 12 Jan 2016, 09:53:10

@Claus.Jensen works great - merged


Mads Rasmussen 12 Jan 2016, 14:02:49

PR: https://github.com/umbraco/Umbraco-CMS/pull/1013

  • added a max height to media items
  • fixed media picker in the template editor
  • added a bit more contrast to folders in selected media for media pickers (I havn't changed the styling much because it has always been like this. What I would like to do someday, is to use the umb-media-grid directive to render the selected images too. It is not possible now, because we can not detect if an item is a folder)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 6

Story Points:

Cycle: