U4-7580 - Make doc type folders renamable

Created by Matt Brailsford 18 Dec 2015, 16:06:48 Updated by Robert Copilau 12 Sep 2017, 06:27:54

Tags: Up For Grabs PR

Is duplicated by: U4-7649

Is duplicated by: U4-7798

Relates to: U4-9143

Parent for: deploy-388

Parent for: COU-616

Subtask of: UAASSCRUM-1073

Once you've made a doctype folder, there doesn't seem to be a way to rename it

Comments

Shannon Deminick 21 Dec 2015, 09:16:47

We'll get to this after the initial release


Lars-Erik Aabech 03 Nov 2016, 10:26:34

I'm grabbing this for the hackathon at uk fest.


Lars-Erik Aabech 03 Nov 2016, 14:50:51

PR'd this and U4-9143 under the same PR starting with U4-7580


Anders Bjerner 03 Nov 2016, 14:53:41

@lars-erik Awesome #H5YR


Claus Jensen 07 Nov 2016, 10:50:40

PR: https://github.com/umbraco/Umbraco-CMS/pull/1580


Lee Kelleher 08 Aug 2017, 17:51:06

Would be great to have this reviewed for an upcoming patch release - given the number of votes and a PR being available.


Shannon Deminick 09 Aug 2017, 05:16:24

definitely, i'll do it today


Lars-Erik Aabech 09 Aug 2017, 07:23:37

#h5yr :)


Shannon Deminick 21 Aug 2017, 09:01:39

NOTE: We also need to make sure that this works with Courier + Deploy ... once we get feedback on the PR we'll see what is involved with the above. Might not make 7.7.0 if there's a bit of work there.


Robert Copilau 30 Aug 2017, 14:42:35

After some testing, even though the feature works as intended, it does not work with Courier or Deploy. It seams that whenever the folder is renamed, it does not trigger the event that makes Deploy/Courier save/update the revision file.

I will try and get to the bottom of this issue at least for Deploy, as Claus put it, I'll probably brake my neck if I would try to fix it for Courier - but I'll try anyway :D

Will that be alright @Shandem? Does this need to be a separate task?


Shannon Deminick 31 Aug 2017, 04:53:04

@Robrobertcopilau ahh yes of course... @claus did remind me of this. In this case we need 2 more tasks: 1 for deploy and 1 for courier, however seeing as though making those updates may take some time, we therefore cannot release this feature as part of 7.6.6 or 7.7.0 it will have to wait for 7.7.x (or potentially 7.6.7 if we make that release) when we are done updating Courier and Deploy and everything is fully tested. If you can create those two tasks and assign them to next sprint then we can start working on them then. We'll also transition this task over to next sprint as well Thanks!!


Robert Copilau 01 Sep 2017, 09:33:18

PR: https://github.com/umbraco/Umbraco-CMS/pull/2166

Changes: *Added missing event to trigger deploy/courier. Has only been tested with deploy but it will probably work with courier as well.

Next step is to test with courier and hopefully will work just as well :)

Edit:

  • It seems that with courier you can't deploy folders from one environment to another, which is another issue all-together. So until we get Courier to deploy folders, this feature doesn't affect it, except that if a folder is renamed in one environment it needs to manually be renamed in the other one too.


Robert Copilau 08 Sep 2017, 09:14:29

Courier has been fixed and now can transfer folders from one environment to another, however the folder rename feature will not work. For more info: http://issues.umbraco.org/issue/COU-621

The problem is that Courier will not detect any changes done to the folder and the nothing will happen. A solution is to rename the folder/s manually.

Unless @Shandem or @claus has any objections this can be merged.


Shannon Deminick 11 Sep 2017, 09:55:06

I guess the only thing missing now is Data Type Folder renames ;)


Lars-Erik Aabech 11 Sep 2017, 10:01:14

I might make it to the hackathon at UK fest. We'll see. ;)


Shannon Deminick 11 Sep 2017, 10:04:51

I think @robertcopilau might beat you to it, we'll see :)


Lars-Erik Aabech 11 Sep 2017, 10:18:49

Go ahead! :) \o/


Robert Copilau 12 Sep 2017, 06:27:54

Don't mind if I do :D


Priority: Up for grabs

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.0

Due in version: 7.7.0

Sprint: Sprint 67

Story Points: 1

Cycle: