U4-7584 - can't preview any content due to external google font

Created by esunxray 20 Dec 2015, 05:36:36 Updated by Claus Jensen 11 Feb 2016, 08:08:35

This bug is still in 7.4 beta

1 Attachments

Comments

Simon Busborg 05 Jan 2016, 11:00:13

PR: https://github.com/umbraco/Umbraco-CMS/pull/988


Claus Jensen 05 Jan 2016, 12:10:23

The reference to Google Fonts has been removed unless you actually try to initialize the canvas designer with the style editor enabled.


James South 04 Feb 2016, 22:32:22

Will the presence of the reference prevent anyone developing while offline?


Claus Jensen 05 Feb 2016, 08:16:16

@JimbobSquarePants You will most likely see the same problem as the reporter, if you actually try using the canvas designer with the style editor enabled while not online, since this scenario depends on a Google Fonts to work.

Normally you would not see any issues though while editing, as we changed it so that only this very specific scenario where it needs the font, tries to actually load in the font. Before it tried loading even if it wasn't needed.


James South 06 Feb 2016, 05:22:58

@claus Hmmmm... Personally I would try to avoid any scenario where I would have to be online to develop. It's not conducive to productivity.

Working while travelling by train or plane where cheap or free wireless is not available for example should be possible. I have frequent connectivity issues at home even and that should stop me being able to work which would be incredibly frustrating. Umbraco, in my opinion should be entirely self contained with no external requirements once installed.


Claus Jensen 08 Feb 2016, 09:06:31

@JimbobSquarePants Normal backoffice editing will not in any way be affected by this and still works perfectly while offline.

This is a very specific scenario where you:

1: Use the 'canvas editing mode', which is not really in any way what I would consider as "done" .. and I honestly can't even really remember right now how to enable it since noone barely uses it.

2: Also have the style editor enabled for canvas editing mode, which supports picking fonts directly from the Google Fonts library.

It would not make sense to have to load in (and keep updated) 500+ Google Fonts in the Umbraco codebase (and on top of that I'm not sure if we are even allowed to do that) - to support a feature we believe is very rarely used by most users, in very rare scenario.


James South 11 Feb 2016, 01:00:36

@claus That's cool then. Thanks for clarifying.


Claus Jensen 11 Feb 2016, 08:08:35

@JimbobSquarePants no problem! Thanks for understanding!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 6

Story Points:

Cycle: