We have moved to GitHub Issues
Created by Morten Bock 21 Dec 2015, 09:58:27 Updated by Claus Jensen 13 Jan 2016, 11:14:44
Create two doctypes Foo and Bar, both with a property called "title". No create a doctype MyPage, and add Foo and Bar as compostitions. When saving the MyPage doctype, a generic "look in the logs" error message is displayed. This is because of conflicting properties on the composition types.
I think that should be a nicer validation message saying "The property 'title' exists on multiple composition types." and probably a suggestion on how to fix this.
PR for review: https://github.com/umbraco/Umbraco-CMS/pull/1009
Test 1: When initially opening the compositions dialog, ct1 and ct2 seems available. Upon clicking either one of them the webservice is called and the filtering method is run and they now show as disabled. The filtering method is not run initally.
Test 2: Both ct1 and ct2 are available when opening the dialog, but when I have selected ct1 and deselect it again - I am no longer able to select ct2 even though it should be available when ct1 has been deselected again.
Test 3: Same as in test 1 and test 2. Initially I don't see the actual state until I try selecting a composition. And after having items disabled in the dialog, going back - removing the title property and then reopening the compositions dialog, they are still disabled.
Test 4: Same as test 2 .. unselecting ct1 wont make the others available.
So @Claus.Jensen what's the conclusion? do you want to put it in reopened?
More testing notes:
claus [4:34 PM] having created ct1 and ct2 .. going to ct2 and adding comp gives me ct1-avail, and ct2-disabled. Saving with ct1 selected and then going back - i dont see ct2 in there anymore
[4:34] its not a problem as such since it would be disabled anyway - but its a bit inconsistent
claus [4:41 PM] and - after adding in a composition and saving, I am no longer able to deselect it from the compositions... that one is a bit worse..
Have pulled this PR in so we can get on with merging other issues in. Most of above has been fixed/tested - one remaining issue will be fixed outside this PR:
Have created a new issue for next sprint on the remaining task here: http://issues.umbraco.org/issue/U4-7707
Backwards Compatible: True
Affected versions: 7.4.0
Due in version: 7.4.0
Sprint: Sprint 6