U4-7641 - Can't copy a document type with new document type tree

I am have this issue also. I am getting a SQL error that there is a duplicate key issue. See this post for error, seems I am not the only one having the issue.

https://our.umbraco.org/forum/umbraco-7/using-umbraco-7/74804-sql-error-copying-a-document-type-in-umbraco-7

Looks like copy process is trying to copy the unique id as well which is suspect is the issue.

The SQL error means that copying might not work in 7.3 - that's one issue. And then the feature has been entirely removed in 7.4 - that's another issue.

Dealing with 7.4... how should copy work with regards to parents: if a content type is copied ''from'' a parent content type, I assume that the copy is not composed of the parent anymore? And it is copied ''to'' a parent content type, I assume that the copy is composed of the new parent?

Can reproduce the 7.3 issue.

7.3 issue fix: missing "_key = Guid.Empty;" in Entity:ResetIdentity().

''If a content type is copied from a parent content type, I assume that the copy is not composed of the parent anymore? And it is copied to a parent content type, I assume that the copy is composed of the new parent?'' That sounds correct to me from an expectations point of view.

7.4 implementation: at the moment the Move action only allows moving to a container (not to a content type). If we want to be consisted, the Acopy action would only allows copying to a container (not to a content type). Thoughts?

Also: as of 7.3 it is not possible to copy media types. Not sure why, will see if it's difficult to add.

PR https://github.com/umbraco/Umbraco-CMS/pull/1146

Adds copy of content types to a container. If the content type has a parent content type, the composition is removed. Other compositions are left unchanged. A new unique alias is assigned to the copy. Children are not copied.

Adding copy to another content type... would make sense if we also added move to another content type, out of the scope of this issue.

Have updated the PR to add copy of media types to a container.

Still having an issue though... with content types the tree is updated, but not with media types?

OK, sorted it out, now up for review.

Review: try to copy content/media types to root or to any folder. Should work. Should not copy children, should preserve compositions except for the parent.

OK looking into it.

See discussion on Slack, we are not opening the target in the tree - that's how it already worked for Move, and that's how it works for Move and Copy for content items in the content tree. So we're consistent accross the UI.

As for the weird behavior you're mentionning - a commit was missing in the PR, updated now. Back to review!

@warren.buckley you haven't merged the PR though?