U4-7687 - Create dialog briefly show "no allowed document types" text

Created by Bjarne Fyrstenborg 09 Jan 2016, 01:23:51 Updated by Simon Busborg 02 Feb 2016, 07:55:22

It seems that when creating a new node, the create dialog briefly show "no allowed document types" text before listing the available document types / content types.

I think is because the bindings isn't ready yet.

I think it can be solved by adding ng-cloak directive to the container.. maybe for umb-pane? it seems it doesn't break the layout that umb-pane has display: none; on init (which ng-cloak directive add)

something like:

<div class="umb-pane" ng-cloak>
	<h5><localize key="create_createUnder">Create an item under</localize> Tall trees have deep roots</h5>

	<p class="abstract">
		<localize key="create_noDocumentTypes">There are no allowed document types available. You must enable these in the settings section under <strong>"document types"</strong>.</localize>
	</p>
</div>

1 Attachments

Comments

Arnoud de Vries 30 Jan 2016, 15:13:30

PR: https://github.com/umbraco/Umbraco-CMS/pull/1075

This problem has been annoying me for some time. It is distracting and gives an unpolished feel to the back office. A similar problem occurs elsewhere:

  • Create document type
  • Create media node
  • Create media type (since Umbraco 7.4)
  • Create data type
  • Create member

@Bjarne.Fyrstenborg adding ng-cloak fixes the problem at the above mentioned other places it occurs. It however still shows the no allowed document types message when creating a content node. ng-cloak only prevents templates from showing before they are compiled. The allowed document types are fetched after the template is compiled. Only when the document types are fetched is the message hidden. I fixed the problem by replacing ng-hide with ng-if for the message part. The message is then only shown when document types are loaded and amount is zero.


Simon Busborg 02 Feb 2016, 07:55:17

PR merged :) #h5yr


Priority: Up for grabs

Type: Cosmetics

State: Fixed

Assignee:

Difficulty: Very Easy

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.0, 7.3.4

Due in version: 7.4.0

Sprint: Sprint 8

Story Points:

Cycle: