U4-7737 - Models Builder - Disabled by default

Created by Shannon Deminick 14 Jan 2016, 12:46:28 Updated by Shannon Deminick 16 Feb 2016, 09:14:42

Tags: ModelsBuilder

Relates to: U4-7738

Relates to: U4-7734

If there are no models builder items in appSettings, then the entire thing should be disabled by default.

This will allow people to seamlessly upgrade from 7.3 -> 7.4 without any issues that might arise from Models Builder.

Of course for new releases, we will include these config options in the web.config so it is enabled when newly installed

Comments

Shannon Deminick 14 Jan 2016, 13:06:45

This also means that the 'generate models' button needs to be removed when it is disabled.


Stephan 15 Jan 2016, 13:07:31

Done - setting Umbraco.ModelsBuilder.Enable must be true for anything to happen.


Shannon Deminick 19 Jan 2016, 10:05:17

I can confirm models are not generated when this setting is not enabled.


Claus Hingebjerg 15 Feb 2016, 21:22:07

i just upgraded a 7.3.4 to 7.4. After installation the site was really slow. inspecting the Umbraco log i found a warning being fired hundreds of times pr. second. "Umbraco.ModelsBuilder.Umbraco.PureLiveModelFactory - No models". Disabling the models builder in web.config fixed it. So its not disabled by default...


Shannon Deminick 16 Feb 2016, 09:14:42

MB is enabled by default - it is the primary way that views will be used in the future with strongly typed models. It is however not enabled by default for upgrades, you need to opt-in to enable it by adding the appSettings keys.

If you have steps to reproduce your issue please open an new ticket with this information. Thanks!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 7

Story Points:

Cycle: