U4-7745 - 7.4 Property Editor & Keyboard Shortcuts

Created by Warren Buckley 15 Jan 2016, 11:23:54 Updated by Mads Rasmussen 25 Jan 2016, 13:16:17

Is duplicated by: U4-7766

Using a nightly build of Umbraco 7.4 build 2462 I have some unexpected behaviour when using keyboard shortcuts, mostly with the item picker dialog (add template, add child node)

Pressing the keyboard shortcut twice (one after another) for add template or add child node displays a blank item picker dialog & a 404 error from the notificationService appears, along with adding a blank item for the child doctype or template in the UI.

The document type cannot be saved & forever hangs when doing this with adding a template.

In addition to this the change section number keyboars shortcut of 1 through to 4 only work with my main numbers (ie with symbols too) but not from my numbers on my keypad to the right.

I have recorded a video going through the keyboard shortcuts to see & how to reproduce these bugs: https://www.dropbox.com/s/tqd00wndtpv0xgd/7.4-build2462_prop-editor-keyboard-bugs.mp4?dl=0

Comments

Mads Rasmussen 20 Jan 2016, 10:37:31

Commit: https://github.com/umbraco/Umbraco-CMS/commit/c16aa5bbf01534872046f0a1cc64cca8d350bd2f

So the issue was that after we have changed the content type editor “sub views/sections” to use a ng-show instead of ng-if (for validation) it now registers all keyboard shortcuts across the sections on load because everything is in the dom.

We have fixed the issue by only allowing execution of a keyboard shortcut if the element, the shortcut is attached to, is visible. We have made an extra attribute for the directive to allow execution of actions on hidden elements. This is used on buttons groups now (save & publish, save etc.).

Tested and reviewed by @Claus.Jensen


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 7

Story Points:

Cycle: