U4-7783 - Member can edit / show on profile don't exist any more in 7.4.0

Created by Sebastiaan Janssen 19 Jan 2016, 14:19:39 Updated by Claus Jensen 24 Jan 2016, 21:48:48

See screenshot. These checkboxes are required for the membership provider to be able to show/edit custom member properties.

1 Attachments

Comments

Shannon Deminick 20 Jan 2016, 09:34:10

@madsrasmussen we cannot release 7.4.0 without this completed. We'll need the UI and back end integrations. This is a super high priority if we want to get 7.4.0 out.


Shannon Deminick 20 Jan 2016, 09:34:43

Assigning to you for now but we'll need to work together on the backend/front-end stuff


Mads Rasmussen 20 Jan 2016, 20:34:44

@Shandem

I have added UI for the member type changes. I have added the two checkboxes to the property settings overlay in member types (when adding a new property to a tab). I have also made small "badges" in the overview to show if a property is mandatory or has these two new settings.

Branch: https://github.com/umbraco/Umbraco-CMS/tree/temp-U4-7783 Commit: https://github.com/umbraco/Umbraco-CMS/commit/504235d6db4467b9cd405a88207c00ed34546232


Shannon Deminick 21 Jan 2016, 15:30:22

PR here: https://github.com/umbraco/Umbraco-CMS/pull/1044

This is all working now. I had to update many of the server side models to split into different content types (since before we were trying to lump it all into one model), so now we have:

  • DocumentType (both basic + display)
  • MediaType (both basic + display)
  • MemberType (both basic + display)

This is required because all three are slightly different. The new models, which is sort of a maze of generics, allow for max flexibility. DocumentType's have template information, but the others don't, MemberType properties have additional information on them, but the others don't, hence the need to make this flexible.

I've added tests to support all the model and mapping changes.

NOTES for tester:

  • Test that you can create/save a Document Type
  • Test that you can create/save a Member Type
  • Test that you can create/save a Media Type
  • Test that you can create/save a Document Type Composition
  • Test that you can create/save a Member Type Composition
  • Test that all server side validation works - try to enter duplicate property and group aliases, along with combining these duplicates with compositions
  • Test that updating member properties with the MemberCanViewProperty and MemberCanEditProperty, ensure all values persist and can be updated


Claus Jensen 24 Jan 2016, 21:48:09

I've tested this and merged it in. Code changes looks good - I removed some code that you commented out as I agree it should not be needed.

There's still some composition validation failing but it is not related to this. As far as I can see it was failing before these changes and they don't really have anything to do with what is failing in my tests - so I figured we might as well get these changes merged in to avoid conflicts on this rather large merge.

I'll create issues for my findings tomorrow.


Priority: Task - Pri 1

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 7

Story Points:

Cycle: