U4-7842 - Query Builder "Sort by" direction button changes case when clicked

Created by Chriztian Steinmeier 26 Jan 2016, 18:34:01 Updated by Simon Busborg 28 Jan 2016, 14:17:13

When opening the Query Builder at first, the toggle button for the direction of the sort says "Ascending" - then when you click it the first time, it changes to "ascending" (a sideeffect because the {{changeOrder()}} function compares it to "ascending"...) and then for the finale, clicking it one last time it goes to "descending" :)

Now, as soon as you actually pick something to sort by, it changes to "ascending"...

Maybe this was a deliberate aesthetic choice to load the dialog with capitalized labels? (I think it's a little weird, though :-)

(I'll submit a PR for it - or if anybody's in the [querybuilder.controller.js file around line 36|https://github.com/umbraco/Umbraco-CMS/blob/fd58c3b3c6b6f0358dd75d03488e323735f70bfb/src/Umbraco.Web.UI.Client/src/views/common/dialogs/template/querybuilder.controller.js#L36] anyways... feel free :-)

Comments

Simon Busborg 28 Jan 2016, 14:16:50

PR: https://github.com/umbraco/Umbraco-CMS/pull/1058 merged.


Priority: Normal

Type: Cosmetics

State: Fixed

Assignee:

Difficulty: Very Easy

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 7

Story Points:

Cycle: