U4-7861 - Moving a ContentType graph breaks parent/child relationships

Created by Stephan 29 Jan 2016, 12:11:43 Updated by Shannon Deminick 03 Feb 2016, 12:59:09

After commits 73f1458190b4a98470cdc0fa4de5f46159ca3e97 and ce3028446b154beaf6b92a19d873af0cc8c36aec the code in ContentTypeBaseRepository.Move now looks like:

//update all descendants, update in order of level var descendants = this.GetByQuery( new Query().Where(type => type.Path.StartsWith(origPath + ",")));

        var lastParent = toMove;
        foreach (var descendant in descendants.OrderBy(x => x.Level))
        {
            moveInfo.Add(new MoveEventInfo<TEntity>(descendant, descendant.Path, descendant.ParentId));

            descendant.ParentId = lastParent.Id;
            descendant.Path = string.Concat(lastParent.Path, ",", descendant.Id);

            //schedule it for updating in the transaction
            AddOrUpdate(descendant);

            lastParent = descendant;
        }

This does not work for graphs. Ie if the structure is that toMove has children child1 and child2, *when child1 is processed, lastParent == toMove and child1.ParentId is set to toMove.Id :: correct *then lastParent is set to child1 *when child2 is processed, lastParent == child1 and child2.ParentId is set to child1.Id :: wrong

Managing paths should be done in the repository, not in the service (see also what we do for content items) but that has other issues with events...

Comments