U4-7881 - version 7.4 beta - cannot add composition doctype to a doctype that has already been saved

Created by doron uziel 02 Feb 2016, 07:33:01 Updated by doron uziel 11 Feb 2016, 06:56:06

I've created a new document type (for the sake of example lets call it Article) compoesd of several other doc-types, and everything works well.

After saving this doc type (and adding some content that uses it - not sure this is relevant), I try to add another composition document type to the 'Article ' doc-type. as soon as I check any doc type in the dialog (as well as uncheck), I receive an error of: "Request error: The URL returned a 404 (not found): /umbraco/backoffice/UmbracoApi/ContentType/GetAvailableCompositeContentTypes"

2 Attachments

Comments

doron uziel 04 Feb 2016, 10:39:44

After further investigation - The problem is with the query string which seems to be very long. This is due to the fact that the doctypes is composed of doc-types that contain a relativlely large amount of fields (which in this case is a 60+). So I am not sure whether this is considered as a bug, as the length of the query string can be configured in the web.config.

Hopefuly this will help others who encounter the same issue.


Shannon Deminick 05 Feb 2016, 08:03:19

Well change it to a post and it should be fine


Claus Jensen 05 Feb 2016, 12:02:31

PR: https://github.com/umbraco/Umbraco-CMS/pull/1100


Claus Jensen 05 Feb 2016, 12:20:25

Test notes:

I've already tested that this fixes the original issue of a too long GET querystring. It requires like 60 properties on a composition to fail, so unless you are really bored don't bother testing that part - just confirm that the dialog still works with a normal composition:

  • Confirm that opening a compositions overlay still works and it now sends a POST request with the query data in body instead of GET with querystring.


Stephan 09 Feb 2016, 13:53:48

Confirming that it works. However, not sure if it is related: when I remove a composition, it says it's going to remove properties and are you sure... check the box, submit: the properties are still in the UI. Save the content type and reload, they are gone. Is this another issue?


Shannon Deminick 10 Feb 2016, 12:20:58

Yup, it's a bug, i'll fix up


Shannon Deminick 10 Feb 2016, 13:36:41

@zpqrtbnk can you have a look at this commit when you get a sec: 4a8b59bdfac72b5d8bafb5099363273d5d452ef4 This fixes this issue - turns out removing the contentTypeId property from that model broke nearly everything to do with removing a composition. It all works now with this change.


Stephan 10 Feb 2016, 13:53:09

works, merging.


doron uziel 11 Feb 2016, 06:56:06

@zpqrtbnk , @Shandem @claus - Very cool - Thank you very much!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 8

Story Points:

Cycle: