U4-7915 - 7.4 RC1: Cannot change grid background

Created by Asbjørn Riis-Knudsen 07 Feb 2016, 11:10:00 Updated by Shannon Deminick 10 Feb 2016, 10:19:29

Relates to: U4-7759

I installed 7.4 RC1 and Fanoe Starter Kit. It seems that U4-7759 is not completely fixed. I can now see the background image in the grid row settings, and I can set a new one, if one is not set already.

However, I cannot change the background image if one is already applied. There is no remove button like in the normal media picker and clicking the image does nothing.

I'd expect there to be a remove button (like the normal media picker).

Comments

Asbjørn Riis-Knudsen 07 Feb 2016, 13:21:48

This seems to be a CSS issue. Removing display:none from the .umb-mediapicker .picked-image rule restores the remove button. From my testing, it does not seem to have any adverse effects elsewhere. However, I suspect it was probably added for a reason...


Asbjørn Riis-Knudsen 07 Feb 2016, 13:38:28

I have created a PR here that removes the display:none rule: https://github.com/umbraco/Umbraco-CMS/pull/1105

However, I am not sure whether this is the correct solution, so please feel free to ignore it.


Mads Rasmussen 09 Feb 2016, 09:07:49

Commit: https://github.com/umbraco/Umbraco-CMS/commit/dc4266852f05f480adbd535a47be17da9dbd4944

@Asbjørn.Riis-Knudsen Thanks for the PR. I will have to fix this issue so it still works the way it used to. When you hover the image the delete button will be display.


Asbjørn Riis-Knudsen 09 Feb 2016, 18:31:35

@madsrasmussen I thought the Umbraco 7 backoffice was supposed to work on tablets (i.e. tocuh devices). If so, relying on hover is no fix for this.


Shannon Deminick 10 Feb 2016, 09:47:19

@arknu Yes the back office does work on touch devices but i agree that some property editors are not exactly touch friendly (i.e. RTE, Grid, there's probably others). I'm not sure what is involved in making the Grid more touch friendly but if you can please open a different ticket for that with the details you require that would be apprecated.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.0

Due in version: 7.4.0

Sprint: Sprint 8

Story Points:

Cycle: