We have moved to GitHub Issues
Created by Shannon Deminick 17 Mar 2016, 12:30:08 Updated by Shannon Deminick 31 Mar 2016, 17:46:03Tags: Backport Community Contrib
Subtask of: U4-5419
umbraco.loadUsers still uses BaseTree/ITree, needs to be re-built with the new tree structure using TreeControllerBase
I can pick up this task.
On a roll! :)
I've managed to get the majority of this task completed. I haven't submitted a PR yet as I have a couple of questions relating to it's implementation:
ActionDisablemenu item was a little tricky to get working. I'm not sure why but the only way I could get
JsFunctionNamepassed client side via the
TreesControllerwas to explicitly add it as a
JsActionKeywhen adding the action to the
MenuItemsCollection. Is there another way to do this or would the below be okay? I had a look at
ConvertLegacyMenuItembut I don't think that will perform the action correctly.
Hey @Dan.Lister ! Best thing to do is submit the PR so we can talk about the specific code directly on GitHub. Any code you keep pushing to that branch is automatically included in the PR before we pull it in.
As for #2 - it should work so there's probably some magic missing. Integrating the new trees with the old editors is an interesting predicament ;)
Thanks @Shandem. I've created a PR and moved my questions above to it: https://github.com/umbraco/Umbraco-CMS/pull/1188
Priority: Up for grabs
Backwards Compatible: False
Due in version: 8.0.0
Sprint: Sprint 12