U4-8189 - migrate user tree to new tree format

Created by Shannon Deminick 17 Mar 2016, 12:30:08 Updated by Shannon Deminick 31 Mar 2016, 17:46:03

Tags: Backport Community Contrib

Subtask of: U4-5419

umbraco.loadUsers still uses BaseTree/ITree, needs to be re-built with the new tree structure using TreeControllerBase

Comments

Dan Lister 18 Mar 2016, 15:04:40

I can pick up this task.


Shannon Deminick 18 Mar 2016, 15:13:03

On a roll! :)


Dan Lister 21 Mar 2016, 14:12:26

I've managed to get the majority of this task completed. I haven't submitted a PR yet as I have a couple of questions relating to it's implementation:

  1. The ActionDisable menu item was a little tricky to get working. I'm not sure why but the only way I could get JsFunctionName passed client side via the TreesController was to explicitly add it as a JsActionKey when adding the action to the MenuItemsCollection. Is there another way to do this or would the below be okay? I had a look at ConvertLegacyMenuItem but I don't think that will perform the action correctly.

https://github.com/danlister/Umbraco-CMS/blob/U4-8189/src/Umbraco.Web/Trees/UsersTreeController.cs#L91

  1. After creating a new user via the create dialog, prior to v8 the back office user would be navigated to the new user's edit user page. After converting, this didn't seem to be the case. Is this something to worry about at this stage?


Shannon Deminick 21 Mar 2016, 15:29:12

Hey @Dan.Lister ! Best thing to do is submit the PR so we can talk about the specific code directly on GitHub. Any code you keep pushing to that branch is automatically included in the PR before we pull it in.

As for #2 - it should work so there's probably some magic missing. Integrating the new trees with the old editors is an interesting predicament ;)


Dan Lister 21 Mar 2016, 20:44:08

Thanks @Shandem. I've created a PR and moved my questions above to it: https://github.com/umbraco/Umbraco-CMS/pull/1188


Priority: Up for grabs

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions:

Due in version: 8.0.0

Sprint: Sprint 12

Story Points:

Cycle: