U4-8194 - migrate dictionary tree to new tree format

Created by Shannon Deminick 17 Mar 2016, 12:34:05 Updated by Warren Buckley 30 Mar 2016, 14:09:38

Tags: Backport Community Contrib

Relates to: U4-5683

Subtask of: U4-5419

umbraco.loadDictionary still uses BaseTree/ITree, needs to be re-built with the new tree structure using TreeControllerBase

Comments

Pete Duncanson 17 Mar 2016, 15:26:34

Is this not a duplicate of http://issues.umbraco.org/issue/U4-8188?


Shannon Deminick 17 Mar 2016, 15:29:15

prob a mistake while i was duplicating issues


Shannon Deminick 17 Mar 2016, 15:29:37

have deleted the other one... probably means I missed one of the other trees - but we'll find it eventually


James Coxhead 17 Mar 2016, 21:38:29

@Shandem I was looking at what it would take to do this recently... I'm happy to take it on.


Shannon Deminick 18 Mar 2016, 09:00:12

@jcoxhead Great! I'll put this in progress and tag. Unfortunately the issue tracker doesn't allow for assigning any user to an issue. I'll work on that today, in the meantime, this one is all yours! If you have any questions, etc... just comment here.


Shannon Deminick 18 Mar 2016, 09:02:39

Oh, I almost forgot, @leekelleher started this a while ago and submitted a PR in progress: https://github.com/umbraco/Umbraco-CMS/pull/609 . His PR was trying to change the entire section (which we will need eventually) but for now all we need to do is replace the tree. Maybe you guys can collaborate on this. I'll link his other issue here: http://issues.umbraco.org/issue/U4-5683


Lee Kelleher 18 Mar 2016, 13:22:19

@Shandem Yeah, I tried to take on too much with my original PR. Think it best to break it down into smaller PRs.

The DictionaryTreeController is already done: https://github.com/umbraco/Umbraco-CMS/pull/609/files#diff-fa438a2e318b81e6699acf9fdbe47481 ... @jcoxhead feel free to take it on.


James Coxhead 18 Mar 2016, 13:58:06

Thanks, I was going to ask what the plan was for "Angularifying" the dictionary. For now I'll get it working with the existing front end and hopefully it should be easy enough to refactor when the time comes.


James Coxhead 24 Mar 2016, 21:11:06

PR submitted based on @leekelleher's earlier PR - using legacy web forms views instead of Angular. https://github.com/umbraco/Umbraco-CMS/pull/1203.


Warren Buckley 30 Mar 2016, 14:09:38

Thanks @jcoxhead approved & merged in !


Priority: Up for grabs

Type: Task

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions:

Due in version: 8.0.0

Sprint: Sprint 12

Story Points:

Cycle: