U4-8593 - Can't use Markdown Editor in custom data types with repeating or nested properties.

Created by Jeremy Pyne 14 Jun 2016, 17:59:48 Updated by Sebastiaan Janssen 11 Aug 2016, 08:29:31

The markdown.editor.js plugin that attaches ui elements for markdown editors locates and attaches controls by ID. It searches the global document for a matching ID not the scope of the Umbraco.PropertyEditors.MarkdownEditorController view as it should. This means that developers trying to use this property in any sort of repeating fashion will not get valid Markdown editors and multiple menu mars will be attached to the first one.

This does not affect normal documents with Markdown Editors as they would all have unique Alias's and thus the Id's would conflict.

This change simply passes the $element scope to the markdown.editor.js and changed the getEmementById to use a scoped jQuery find instead.

https://github.com/umbraco/Umbraco-CMS/pull/1331

1 Attachments

Comments

Claus Jensen 29 Jul 2016, 09:50:03

Hi @Jeremy.Pyne

@madsrasmussen and I have been through your PR and unfortunately modifying anything in the lib folder is not an option as it is external libraries. It should however be possible to achieve a similar solution by using the postfix option already built into the markdown plugin.

When we tried to replicate the issue it however seems like the current version of the Nested Content plugin does not have this problem due to using ng-if to only show one active item at a time. I'm closing the PR for now and encourage you to upgrade to the latest version of Nested Content to avoid the issue.

If you encounter any further issues with this that can't be fixed by using latest versions, could you please submit a new issue with updated instructions on how to replicate exactly that scenario. Then we will look into getting the editors scoped using the postfix option instead.

Best, Claus / Mads


Priority: Minor

Type: Bug

State: Closed

Assignee:

Difficulty: Very Easy

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.3

Due in version:

Sprint:

Story Points:

Cycle: