U4-8612 - Umbraco v7.5-beta - Icon doesn't show in local package installer

Created by Jeavon Leopold 20 Jun 2016, 12:06:03 Updated by Shannon Deminick 05 Aug 2016, 11:07:16

Tags: PR

I have updated UmbracoFileSystemProviders.Azure to include the new IconUrl for testing, you can take the Zip from https://ci.appveyor.com/project/JamesSouth/umbracofilesystemproviders-azure/build/artifacts

1 Attachments

Comments

Jeavon Leopold 20 Jun 2016, 12:08:11

PR https://github.com/umbraco/Umbraco-CMS/pull/1338/files


Jeavon Leopold 20 Jun 2016, 12:11:50

Result is so tiny but so nice :)


Shannon Deminick 28 Jun 2016, 14:36:28

ah, this is great, i had thought we'd have to make an Icon Url field - looks like we don't need that. I'll pull in and update where applicable, thanks!


Jeavon Leopold 28 Jun 2016, 15:16:40

You had already added it to the Installer just needed to get the data to the UI via the API controller.

Now how about adding a Icon field to manage package on Our, ah, that's a different tracker :)


Shannon Deminick 28 Jun 2016, 17:02:37

Yup, figuring all this out now :) The IconUrl will be a field when you create a package in the back office in 7.5+ and will be part of it's manifest.


Jeavon Leopold 28 Jun 2016, 17:10:08

Yes, perfect


Kevin Jump 05 Aug 2016, 07:52:11

Hi Just Looking I can't see this PR in the Dev-v7 Branch anymore? https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI.Client/src/views/packager/views/install-local.html#L72

html says vm.localPackage.icon when it should be vm.package.iconUrl

I am reasonably sure I am looking at the right file

also i think repo.html and installed.html also need icon changing to iconUrl, but i wanted to make sure i was looking the right place before doing anything


Shannon Deminick 05 Aug 2016, 08:36:01

fairly sure we've just streamlined the naming of the icon property - you can retest if you run from the latest vs solution in dev-v7 branch. I'll see what I can find today as well.


Jeavon Leopold 05 Aug 2016, 10:31:59

I think maybe this has been mistakenly merged out, the other changes are still in place so there will be a mismatch in the model...


Shannon Deminick 05 Aug 2016, 11:03:27

Hrm, does seem odd! I'll fix this up


Shannon Deminick 05 Aug 2016, 11:07:16

all fixed up in rev: 3e932ecf3fdd527795b805cc319dd569e8a3bea6


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.5.0

Due in version: 7.5.0

Sprint: Sprint 36

Story Points:

Cycle: