U4-8617 - 7.4.3 gets parent property in content tree in view

Created by Denise del Bando 20 Jun 2016, 21:08:12 Updated by Sebastiaan Janssen 30 Jul 2018, 15:25:54

Tags: Up For Grabs PR

Is duplicated by: U4-7608

Is duplicated by: U4-8874

I am using V7.4.3 (was upgraded from Umbraco 7.2.8)

was successful. Now i see a major issue.

Here is my document type hierarchy

I have three document types called Section Landing and Event Landing and Home page all inheriting from a master document that has SEO properties.

Homepage and Section Landing has a property called 'spotlightContent' BUT NOT Event Landing

Section Landing and Event Landing parent page in the content tree is HomePage

Section Landing and Event landing SHARE THE SAME PAGE TEMPLATE. In this template, it displays spotlightContent. In Version 7.2.8, if the page doesnt have this property, it just ignores it completely. But in 7.4.3, the Event landing page is getting the spotlightContent from the Homepage instead of ignoring it.

Is there any quick fix to this? Please help. I tested it in 2 different environments, same installation, same issue :(

I run umbraco in incognito mode.

any help is appreciated. thank you.

https://our.umbraco.org/forum/using-umbraco-and-getting-started//78139-umbraco-v743-gets-parent-property-in-content-tree

Comments

Denise del Bando 21 Jun 2016, 14:24:49

I tried to replicate it on a fresh install, it doesnt happen.

My site is also in webforms.. and majority of the pages use masterpages. maybe this info will help.

... another update.. I was able to replicate this behaviour in a webforms mvc fresh installation

It is easier to show you how to replicate. I decided to record a video. its just 5 minutes long.

https://youtu.be/2O1FJBXmfgA


Denise del Bando 21 Jun 2016, 17:51:40

quick fix: but not ideal cause now I have to update all properties from <umbraco:Item field="testProperty" runat="server"></umbraco:Item> to: <umbraco:Macro runat="server" language="cshtml"> @using umbraco.MacroEngines @if(Model.testProperty != null && !string.IsNullOrEmpty(Model.testProperty.ToString())){ @Html.Raw(Model.testProperty) } </umbraco:Macro>


Jannes Meyer 19 Aug 2016, 13:46:58

It still happens for me with Umbraco 7.5.0. Maybe it's also worth mentioning that in my case it is an Umbraco install that started out on v4 and was upgraded over time.


Sebastiaan Janssen 20 Aug 2016, 13:35:24

Looks like we need to check if recursive is actually true here: https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/umbraco.presentation/item.cs#L67


Sebastiaan Janssen 20 Aug 2016, 13:38:09

Seems to have been introduced here: https://github.com/umbraco/Umbraco-CMS/commit/697daab4d75f28a8bb2640af66f35094d26e4ff5

If anyone wants to send a pull request then we can include the fix in the next version!


Poornima Nayar 15 May 2018, 18:33:58

I have submitted a PR https://github.com/umbraco/Umbraco-CMS/pull/2631


Priority: Up for grabs

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.5.0, 7.3.2, 7.3.3, 7.3.4, 7.4.1, 7.3.5, 7.3.6, 7.3.7, 7.3.8, 7.4.2, 7.4.3

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: