U4-8663 - Deleting the last property on a tab causes it to end up at Generic Properties tab

Created by Claus Jensen 27 Jun 2016, 10:21:24 Updated by Sebastiaan Janssen 04 Aug 2016, 12:09:03

Relates to: U4-8798

Relates to: U4-8631

What did you do?

  • Saved a doctype with 1 tab and 1 property
  • Delete that 1 property to have an empty tab left
  • Save the document type

What did you expect to happen? Expected the property to be deleted and (maybe?) the tab deleted also due to not allowing empty tabs.

What actually happened? The property was moved to Generic Properties and my tab was deleted.

Comments

James Coxhead 15 Jul 2016, 16:23:03

I've also noticed this on a few of my sites running 7.4.3


Stephan 19 Jul 2016, 06:33:29

Reproduced


Stephan 19 Jul 2016, 08:03:14

Cause: when deleting a tab, ContentTypeBaseRepository moves the property types to 'generic properties'. I guess this was to prevent accidental deletions but, really, when a tab is going all its properties should be going too.

And then: there are other weird situations such as moving a unique property to a new tab (instead of deleting it). Currently going through ContentTypeBaseRepository.PersistUpdatedBaseContentType to try and understand it all.


Stephan 19 Jul 2016, 08:48:33

Fixed + fixed these other weird situations, ContentTypeBaseRepository has flaws. Should be OK now.

PR: https://github.com/umbraco/Umbraco-CMS/pull/1386

Review: ensure that the test case in the description now works, also: instead of deleting the property, create a new tab and move the property to that new tab. Should work.


Warren Buckley 21 Jul 2016, 10:34:00

Tested the original & new test you wish for me to test @zpqrtbnk all works as described. Off to test & sanity check the code before marking as fixed.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.5.0, 7.4.3

Due in version: 7.5.0

Sprint: Sprint 38

Story Points:

Cycle: