We have moved to GitHub Issues
Created by Claus Jensen 27 Jun 2016, 10:21:24 Updated by Sebastiaan Janssen 04 Aug 2016, 12:09:03
Relates to: U4-8798
Relates to: U4-8631
What did you do?
What did you expect to happen? Expected the property to be deleted and (maybe?) the tab deleted also due to not allowing empty tabs.
What actually happened? The property was moved to Generic Properties and my tab was deleted.
I've also noticed this on a few of my sites running 7.4.3
Cause: when deleting a tab, ContentTypeBaseRepository moves the property types to 'generic properties'. I guess this was to prevent accidental deletions but, really, when a tab is going all its properties should be going too.
And then: there are other weird situations such as moving a unique property to a new tab (instead of deleting it). Currently going through ContentTypeBaseRepository.PersistUpdatedBaseContentType to try and understand it all.
Fixed + fixed these other weird situations, ContentTypeBaseRepository has flaws. Should be OK now.
Review: ensure that the test case in the description now works, also: instead of deleting the property, create a new tab and move the property to that new tab. Should work.
Tested the original & new test you wish for me to test @zpqrtbnk all works as described. Off to test & sanity check the code before marking as fixed.
Backwards Compatible: True
Affected versions: 7.5.0, 7.4.3
Due in version: 7.5.0
Sprint: Sprint 38