U4-8716 - Constants-Examine.cs are missing some constants

Created by Anders Bjerner 08 Jul 2016, 10:58:14 Updated by Claus Jensen 16 Aug 2016, 11:50:30

Tags: PR Community Contrib

The file only contains two constant properties, while others make sense as well: Pull request here: https://github.com/umbraco/Umbraco-CMS/pull/1376/files

Comments

Warren Buckley 19 Jul 2016, 14:30:35

The constants you have added @abjerner look fine & make sense to be added, but as Shannon mentioned earlier on the GitHub issue it makes sense to update your PR to use these constants throughout the codebase.

Will set this to re-opened for now. If you need advice or pointers where to look just shout, but I am sure a simple find reference or find in SLN will give you what you need :)


Claus Jensen 16 Aug 2016, 11:34:16

@abjerner Thanks for the PR - I've pulled it in and fixed up the places where we didn't use the examine constants in the codebase :)


Anders Bjerner 16 Aug 2016, 11:48:09

@claus Awesome. I had promised Warren to do that, but had totally forgotten about it :/


Claus Jensen 16 Aug 2016, 11:50:30

@abjerner No problem - we all have busy periods :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.3

Due in version: 7.5.0

Sprint: Sprint 40

Story Points:

Cycle: