U4-8768 - New packager - remove inline styles from package description

Created by Bjarne Fyrstenborg 22 Jul 2016, 22:03:05 Updated by Sebastiaan Janssen 11 Aug 2016, 08:29:46

Tags: Unscheduled PR

Relates to: OUR-405

Relates to: OUR-406

On our.umbraco.org when editing package description, there is no buttons the remove inline styling (I think TinyMCE have some buttons for that "removeformat" and/or "cleanup" - http://archive.tinymce.com/wiki.php/TinyMCE3x:Buttons/controls)

Anyway since the current package descriptions on Our actually let you copy/paste some HTML-content from any other website (which might contain inline style), we can remove inline styles and classes to keep it consistency, when viewing packages from backoffice. Furthermore I think some class actually could break a part of the UI in backoffice or make in inconsistency if the package description contains a class the conflict with classes in Umbraco.

Comments

Bjarne Fyrstenborg 22 Jul 2016, 23:52:58

PR: https://github.com/umbraco/Umbraco-CMS/pull/1397


Simon Busborg 28 Jul 2016, 08:49:51

Hi @Bjarne.Fyrstenborg. Super idea of getting rid of the inline styling in the descriptions for a more semantic experience and look when viewing packages. (And thanks for the contribution 🙌)

We want to do it in another way than stripping classes and inline styles with regular expression. We'll create a task that contains cleaning up existing packages and adding a markdown editor for creating descriptions.


Simon Busborg 28 Jul 2016, 08:53:33

Tasks: http://issues.umbraco.org/issue/OUR-405 & http://issues.umbraco.org/issue/OUR-406


Bjarne Fyrstenborg 31 Jul 2016, 21:02:21

Thanks @simonbusborg ... I think also we should adjust the styles inside package description a bit, e.g. headings (h1-h6), where h1 is quite large compared to the package name at top - but it might be fine other places in backoffice UI. Also ensure any images and embed objects like YouTube videos fit within the package description wrapper.


Priority: Normal

Type: Cosmetics

State: Closed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.5.0

Due in version:

Sprint:

Story Points:

Cycle: