U4-8799 - Validation and/or feedback when creating properties that could cause issues with ModelsBuilder

Created by Morten Christensen 02 Aug 2016, 10:19:30 Updated by Shannon Deminick 04 Aug 2016, 14:55:09

Tags: Unscheduled

When using the DocumentType editor in 7.4.3 you can create a Document Type called "Survey" and a Property Type called "Survey". Innocent at first glance, but if you are using ModelsBuilder models (which is now on by default) you have created an issue for yourself, because ModelsBuilder will generate a class called "Survey" with a property called "Survey", which is not valid C#. If you go to the ModelsBuilder dashboard (3rd tab in the Developer section) you will discover the issue, but if you simply go to the frontend of the website you will get a cryptic error that doesn't say anything about the ModelsBuilder issue.

Suggestion: The DocumentType editor should validate the Property Type alias, so it doesn't clash with the alias of the Document Type. It should be apparent to the user that creating a doc type called "Survey" with a property type also called "Survey" would result in an invalid model.

To the extent its possible it would be nice if the view exception around invalid models would show or at least indicate that the issue is with ModelsBuilder (and that additional information can be found in the ModelsBuilder dashboard - or show the details from the ModelsBuilder error in the exception?). Either way, just a suggestion...

Comments

Sebastiaan Janssen 02 Aug 2016, 11:41:53

PR: https://github.com/zpqrtbnk/Zbu.ModelsBuilder/pull/115


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.3

Due in version: 7.5.0

Sprint: Sprint 39

Story Points:

Cycle: