U4-8814 - Html.Wrap adds children twice

Created by David Peck 05 Aug 2016, 10:09:06 Updated by Claus Jensen 08 Aug 2016, 08:46:02

Tags: Unscheduled PR

Html.Wrap(this HtmlHelper html, bool visible, string tag, string innerText, object anonymousAttributes, params IHtmlTagWrapper[] children)

Calls another overload, supplying the children, resulting in the children getting added. However it then also adds the children itself. This results in the children beinig added twice.

I'll create a pull request...

Comments

David Peck 05 Aug 2016, 10:15:53

Ok, that's my first pull request I've created so apologies if I've not done it correctly. Let me know if you don't have it.


Sebastiaan Janssen 05 Aug 2016, 10:28:47

A link would be handy ;-)


Shannon Deminick 05 Aug 2016, 10:30:24

https://github.com/umbraco/Umbraco-CMS/pull/1418


David Peck 05 Aug 2016, 10:54:19

A link to the pull request I assume: https://github.com/umbraco/Umbraco-CMS/pull/1418


Claus Jensen 08 Aug 2016, 08:45:53

Thanks for the PR - nice catch :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.4.3

Due in version: 7.5.0

Sprint: Sprint 39

Story Points:

Cycle: