U4-8844 - Dialogs has rounded corners

Created by Bjarne Fyrstenborg 11 Aug 2016, 11:36:47 Updated by Sebastiaan Janssen 16 Aug 2016, 11:11:15

Tags: Unscheduled PR

I am using Umbraco as a Service with v7.4.3 I have also installed LeBlender v1.0.8.4

The Trace log viewer overwrite the core styling, which makes the dialog much wider. An issue is created here: https://github.com/DanDiplo/UmbracoTraceLogViewer/issues/18

Besides that the bottom has rounded corners. "None" is not a valid value for border-radius - it should be "0" instead.

It is not an issue with the core umb-overlay dialog since it doesn't use the class modal.

I think it is affected by this line: https://github.com/umbraco/Umbraco-CMS/blob/75c2b07ad3a093b5b65b6ebd45697687c062f62a/src/Umbraco.Web.UI.Client/src/less/modals.less#L128

3 Attachments

Comments

Bjarne Fyrstenborg 11 Aug 2016, 16:52:55

PR: https://github.com/umbraco/Umbraco-CMS/pull/1429


Priority: Normal

Type: Cosmetics

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.4.3

Due in version: 7.5.0

Sprint: Sprint 40

Story Points:

Cycle: