U4-8861 - Extract GlobalSettings to an interface and expose on the standard UmbracoConfig.For settings singleton

Created by Shannon Deminick 17 Aug 2016, 08:43:10 Updated by Shannon Deminick 06 Apr 2018, 03:53:38

Comments

Shannon Deminick 17 Aug 2016, 11:13:20

Have pushed a branch temp-U4-8861 with this change

Changes made:

  • New IGlobalSettings interface
  • Exposed publicly via the normal UmbracoConfig.For syntax
  • Moved some variables to 'Constants'
  • Left some static props internal on GlobalSettings with TODO notes in there

TODO:

  • Fix up unit tests to use correct mocking config class instead of hacking the appsettings
  • Test


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 8.0.0

Sprint:

Story Points: 0

Cycle: