U4-8868 - Adding hostname does not work in Umbraco 7.5.0

Created by Claus Jensen 18 Aug 2016, 09:55:58 Updated by Sebastiaan Janssen 19 Aug 2016, 13:56:53

Tags: Unscheduled

Is duplicated by: U4-8875

After upgrading jQuery .live() is no longer just deprecated but actually removed. We need to update all instances where this is still used in the codebase.

1 Attachments

Download AssignDomain2.js

Comments

Claus Jensen 18 Aug 2016, 10:50:25

PR: https://github.com/umbraco/Umbraco-CMS/pull/1442

'''Test:'''

  • Confirm that the dialog to assign domains/languages on a node isn't broken anymore.
  • Maybe also check the other components that were updated (MNTP and FolderBrowser) ... if you know how/where to find and test these.

.live() vs .on() is however only a small change, so if you can confirm it works in the domain dialog the others should be fine too.


Sebastiaan Janssen 18 Aug 2016, 13:32:56

The manual workaround: In ~\Umbraco_Client\Dialogs\AssignDomain2.js, line 89, change live to on.

I've attached the corrected file.

After changing this file, makes sure to change the version in ~\Config\ClientDependency.config so the javascript cache gets invalidated.


Jeroen Breuer 19 Aug 2016, 08:52:14

I also just run into this issue. Any idea when 7.5.1. will be out?


Sebastiaan Janssen 19 Aug 2016, 09:26:18

Soon. There's a manual fix changing 4 characters of text or dropping a file into the correct location just above your comment.


Jeroen Breuer 19 Aug 2016, 09:58:19

Yes I already applied that fix. Thanks for the workaround. It just took me some time to find the fix here. So hopefully with 7.5.1 other developers won't lose time.


Sebastiaan Janssen 19 Aug 2016, 10:15:23

Yes. It's coming next week.


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.5.0

Due in version: 7.5.1

Sprint: Sprint 40

Story Points:

Cycle: