U4-8890 - Umbraco Install doesn't honour configSource in ConnectionSettings

Created by Kevin Jump 23 Aug 2016, 07:44:02 Updated by Sebastiaan Janssen 16 Mar 2018, 14:56:53

Tags: PR

Running the Umbraco Install with a web.config where the connectionStrings have been moved out the config using a configSource line

<connectionStrings configSource="config\connectionStrings.config">
</connectionStrings>

when you install, the Installer just places the config string directly into this block resulting in a YSDO

It would be nice if the Installer honoured the configSource and placed it's connectionString into the file pointed to by configSource, this makes the scenario where you have moved the connectionString for source control purposes, a bit easier to manage.

Requires changing SaveConnectionString in DatabaseContext to be aware of the configString and use that file in the place of web.config (PR to follow)

Comments

Kevin Jump 23 Aug 2016, 07:57:49

https://github.com/umbraco/Umbraco-CMS/pull/1445


Brian Lacy 26 Sep 2016, 15:59:02

I really need this fix; I'm not sure why it's been ignored for so long. To me it seems pretty crucial for anyone who uses source control.

Incidentally -- this is needed for appSettings, too! When the Upgrade/Installer overwrites the version string in appSettings.umbracoConfigurationStatus, it ignores the configSource attribute and screws up the web.config by replacing the appSettings.


Brian Lacy 26 Sep 2016, 16:10:34

I've added a new issue for AppSettings: http://issues.umbraco.org/issue/U4-9020


Priority: Normal

Type: Feature (request)

State: Fixed

Assignee:

Difficulty: Normal

Category: Installation

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.10.0

Sprint:

Story Points:

Cycle: