We have moved to GitHub Issues
Created by Sebastiaan Janssen 22 Sep 2016, 10:41:16 Updated by Shannon Deminick 29 May 2017, 18:16:07Tags: Unscheduled
Is duplicated by: U4-9607
Relates to: U4-9005
URLRewriting.net is old, leaks memory and takes a lot of CPU and slows down starting the website when there's more than a few rules.
Use the IIS Rewrite plugin instead.
Note to contributors: make sure to target the
dev-v8 branch for this.
Just made a PR that addresses this issue. I am however not sure if it's as easy as i imagine. Please guide me if I'm way off :)
Note: upgraders will still have the config file and references in web.config. I was going to make a web.config transform to remove the rewrite bits but realized we don't want to do that in case people are actually using this module, it would break all their rewrites.
Fresh installs won't have URLRewriting.net any more as of 7.6.0.
UrlRewritingNet.UrlRewriter.dllshould be left in the bin folder
UrlRewritingNetshould be left in the NuGet packages we produce
urlrewritingnetshould remain in web.config
urlrewriting.configshould remain in the config folder
Marked as not backwards compatible because it changes the expectation of this module being available out of the box. If this is still a requirement for someone they can install the
UrlRewritingNet package in their solution and use it like before (http://nuget.org/packages/UrlRewritingNet).
Our recommendation is to use IIS rewrites instead for perfomance and standardization reasons.
An upgrade will leave the urlrewriting thing in the web.config but the actual urlrewriting config file is removed - unless perhaps it's been modified. I didn't modify mine and it got removed on upgrade, i'll re-test after I've modified
Yup, if it's modified it doesn't remove it so all good there
What's the feeling towards having the IIS Rewrites in a separate file by default? It's not difficult to do, but there's a couple of gotchas involved for someone (=> me) who doesn't do this every day.
If it was already setup with a few examples in a comment in the file, and a link for further exploration, just like the UrlRewriting.config file did, it should be easy to "get".
I know that's definitely what kept me on the UrlRewriting path for way too long, even though clever people like yourselves told me there was a better way :-)
One problem with that is that the
<!-- If you wish to use IIS rewrite rules, see the documentation here: https://our.umbraco.org/documentation/Reference/Routing/IISRewriteRules <rewrite> <rules> </rules> </rewrite> -->
I have added this to the default web.config now and added docs
@Shandem I moved that part into system.webServer to avoid confusion.
I will update the ReadmeUpgrade.txt file
Difficulty: Very Easy
Backwards Compatible: False
Due in version: 7.6.0
Sprint: Sprint 54