We have moved to GitHub Issues
Created by Mads Rasmussen 13 Oct 2016, 09:16:14 Updated by Sébastien Sougnez 05 Aug 2018, 20:51:47
We need to remove the webforms “send to translation” dialog in the back office and replace it with angular. This requires a bit of work on both the client and server side.
I have added the angular view and controller for the dialog and we need to wire up the server side. I have started this PR for collaboration: https://github.com/umbraco/Umbraco-CMS/pull/1520
I would like to work on this PR. How can I do? Can I simply pull the branch "temp-U4-9063" and work on it?
That would be awesome. The other PR is 2 years old so it might be better to start fresh with a new branch. If there is anything you can use in that PR feel free to just copy it over.
I did a "git merge dev-v7" branch and I had no conflict. I guess it means that it will be OK when I push my changes, won't it?
For the reuse, I'm editing the view you created (and renamed it to make it work). It's a good thing that you did this as the most complex thing to get when trying to extend/improve Umbraco is the CSS :-D Here, everything is almost done, so that's cool :-D
''Btw, something really needs to be done for this issue tracker, it's barely usable ^^''
I have a question. The current page calls "umbraco.cms.businesslogic.translation.Translation.MakeNew" method but the whole class is marked as deprecated. Does a new implementation already exist? I search and didn't find anything. If not, are there any spec for the new service or can I create it from scratch?
@ssougnez I had to have a quick dig through it but you can find it over here
Yup yup, I saw this, however, it seems weird to implement all the logic in the web service route while other one calls services. Wouldn't it be better to create a "TranslationService" with "MakeNew" method that would mimic "umbraco.cms.businesslogic.translation.MakeNew" but only using "not deprecated" stuff?
I decided to add a method to the ContentService (SendToTranslate). I'll commit in the upcoming days what I did then we'll discuss it as I'm sure it won't be perfect :-D (There is soooooo many thing to pay attention to hehe... Great tool... Love it :p)
That is absolutely amazing. We're looking forward to your PR!
About the issue tracker, we know it doesn't perform, and we are currently working on a better solution.
State: In Progress
Backwards Compatible: True
Due in version: