U4-9091 - Media Picker - inconsistent font-face

Created by Lee Kelleher 21 Oct 2016, 10:03:52 Updated by Sebastiaan Janssen 03 Nov 2016, 14:09:39

Tags: Up For Grabs PR

''''' This should be a nice easy one for UK Festival Hackathoners :-) '''''


When using the Media Picker, the font-face used to display the text/name of the selected media item is not consistent with the back-office.

!media-picker-font.png!

The reason is that the web-font "icomoon" is being used to display the icon, but also the text/name. In the HTML, a class name of "icon-holder" is being used on the containing <span>. Which is inheriting a CSS rule that sets the icon font.

A fix would be to prefix the CSS class for "icon-holder" with "umb-" (e.g. "umb-icon-holder"), in both the CSS/LESS and view files. This will keep the contents centred and use the proper inherited font-family.

1 Attachments

Comments

Chris Houston 03 Nov 2016, 11:48:40

Fixed: https://github.com/umbraco/Umbraco-CMS/pull/1575


Priority: Minor

Type: Cosmetics

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.5.5

Sprint:

Story Points:

Cycle: