U4-9193 - Install error label doesn't go away at Database step

Created by Pete Duncanson 16 Nov 2016, 13:14:33 Updated by Claus Jensen 12 Jul 2017, 13:48:20

Tags: Up For Grabs Unscheduled PR

Subtask of: U4-9609

During install, click on "Customise" and try to connect to a database with a non-existent server name (in my case I'd misspelt it). Click "connect" or whatever the button is at the bottom. A label (lets call it "label 1") appears telling you its "validating the connection" and then it should fail (as your db doesn't exist) and you'll get a "couldn't connect to database" red label appear ("label 2") in place of label 1.

Now try again with another incorrect database name (or just click "connect" again) and you'll see label 1 shows up again but label 2 is still there.

Simply need to remove label 2 when the button is clicked.

Comments

Pete Duncanson 06 Jan 2017, 20:35:10

This seems to be the place to look: https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI.Client/src/installer/steps/database.html


Pete Duncanson 06 Jan 2017, 20:41:03

Pull request created: https://github.com/umbraco/Umbraco-CMS/pull/1678


Claus Jensen 12 Jul 2017, 13:47:47

Thanks for the PR :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Easy

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.6.4

Due in version: 7.6.5

Sprint: Sprint 63

Story Points:

Cycle: