U4-9201 - Database conflicts in background threads

Created by Stephan 18 Nov 2016, 08:33:00 Updated by Shannon Deminick 16 May 2017, 02:09:06

Relates to: U4-9907

When running Deploy and it tries to restore content in a background thread, we are seeing database conflicts because several background threads end up using the same database connection (stored in logical call context) at the same time.


Stephan 18 Nov 2016, 08:46:51

PR https://github.com/umbraco/Umbraco-CMS/pull/1628

This is against 7.6 because it's needed for Deploy - need to discuss whether it should be moved against 7.5.

Stephan 22 Nov 2016, 16:17:06

Happy with the changes. They should NOT go into 7.5 as they quite probably break 301Tracker and others. Review = tricky... probably, code review + "everything" should still work.

Shannon Deminick 28 Nov 2016, 09:43:15

Lots of changes there which I think look fine, at least nothing alarming that I can see in the code. If tests are passing this is fine since we'll be testing a lot more once we are all on 7.6/Deploy.

Shannon Deminick 28 Nov 2016, 09:58:07

Set to a 'breaking change' due to the fact that things must be disposed on EndRequest, any packages using EndRequest may not work anymore and they will need to be updated to use either an HttpModule even that occurs before end request or use a new event: UmbracoModule.EndRequest. Full details are listed on the 301 redirect tracker https://github.com/kipusoep/UrlTracker/issues/146

Priority: Normal

Type: Bug

State: Fixed


Difficulty: Normal


Backwards Compatible: False

Fix Submitted:

Affected versions: 7.5.4

Due in version: 7.6.0

Sprint: Sprint 47

Story Points: 1